Repository navigation
fix(autoware_vehicle_info_utils): replace deprecated share-directory API in test for Lyrical - #1
Merged
Merged
Conversation
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
mdlopezme
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This makes
autoware_vehicle_info_utils' unit test compile on ROS 2 Lyrical.autoware_cmake1.4.0 compiles with-Werror. On Lyrical,ament_index_cpp::get_package_share_directory()is deprecated in favour ofget_package_share_path(), which returns astd::filesystem::path. The test called the deprecated function to find its param file, so the package failed to build wheneverBUILD_TESTING=ON.The test now builds that path with
get_package_share_path("autoware_vehicle_info_utils") / "config/vehicle_info.param.yaml".This is a test-only change; the library itself is untouched.
Related links
race_commonmigration to ROS 2 Lyrical (awsim profile): the simulator depends onautoware_vehicle_info_utils.autowarefoundation/autoware_coremainstill has the deprecated call, so this change could be offered upstream too.How was this PR tested?
The environment was Ubuntu 26.04, ROS 2 Lyrical, GCC 15.2, CMake 4.2 and
autoware_cmake1.4.0.colcon build --packages-select autoware_vehicle_info_utils(Release,BUILD_TESTING=ON) passes.colcon test: 42 tests, 0 errors, 0 failures, 8 skipped.race_common'smake awsim(all 47 packages).Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.