Reject duplicate Content-Length headers#12389
Open
metsw24-max wants to merge 1 commit intoaio-libs:masterfrom
Open
Reject duplicate Content-Length headers#12389metsw24-max wants to merge 1 commit intoaio-libs:masterfrom
metsw24-max wants to merge 1 commit intoaio-libs:masterfrom
Conversation
Member
|
Needs a test to reproduce the issue. I'm pretty sure duplicates are already rejected (atleast server-side). |
Dreamsorcerer
added
the
pr-unfinished
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This change makes the Python HTTP response parser reject responses with multiple
Content-Lengthheaders by usingheaders.getall()and raisingBadHttpMessage. This aligns behavior with the C parser and removes ambiguity in message framing.Are there changes in behavior for the user?
Yes. Previously only the first
Content-Lengthheader was used. Now, responses with more than oneContent-Lengthheader will be rejected withBadHttpMessage.Is it a substantial burden for the maintainers to support this?
No. The change is small, localized, and improves correctness and consistency without adding maintenance complexity.