Repository navigation
fix: report worker failures during collection - #602
Closed
simone-chen wants to merge 2 commits into
Closed
simone-chen wants to merge 2 commits into
simone-chen wants to merge 2 commits into
Conversation
Signed-off-by: Simone Chen <simonec@nvidia.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
Contributor
Author
|
/ok to test 48dbc99 |
Signed-off-by: Simone Chen <simonec@nvidia.com>
Contributor
Author
|
/ok to test 7c5c519 |
Contributor
Author
|
Closing as outside the requested review scope: retain only attention #604, recurrent/MoE #605, and communication #591 for Tianhao's review. This campaign infrastructure change is not merged or included in the replacements. Its branch and history remain available for separate future work; collection remains stopped. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
simonec/vllm031-b200-campaign-v2; implementation is one commit from immutable campaign source6ec6925fabf863ffc2bfe46442b726448c70ce98. The logging commit changes onlycollect.py, its README and parallel-run tests. A separate follow-up repairs inherited ownership coverage for four campaign checkpoint files; it adds the existing FPE/maintainer owners through the policy generator. Eventual publication remains main-only; this draft does not merge or alter campaign pins.