Repository navigation
fix: align Kimi verify collector with native state layout - #597
Closed
simone-chen wants to merge 1 commit into
Closed
simone-chen wants to merge 1 commit into
simone-chen wants to merge 1 commit into
Conversation
simone-chen
commented
Oct 26, 2026
Contributor
- Kimi 0.31 verify previously failed the qualification gate; its legacy fixture also used zero-based checkpoint IDs, an extra conv-history column and contiguous Q/K/V unrelated to convolution output. Use the native dtype/shape calculators and cache binding, reserve null slot 0, and pass actual packed convolution output to recurrence.
- Admit only the fixed B200/SD/BF16 input+conv/FP32 recurrence/non-RecoverSSM verify profile. Query width S fixes num_spec=S−1 and accepted=S. Preserve the four registered callback identities, 108 shape points, 216 planned conv/recurrence rows and their separate timing callbacks. Generation, preview and GLM behavior remain unchanged; no schema or consumer changes.
- Stack on fix: release completed KDA prefill buffers #595. Validate with 73 CPU contract tests and Ruff; callback/getter AST checks confirm unchanged generation, prefill, entry point and both verify timer bodies. Tests cover all four local-head counts, all three widths, cache/input strides, positive IDs, preview behavior and explicit failure propagation.
- Isolated B200 numerical job 2389279 passed all 36 conditional fixtures; only its six auto verify contexts support this repair. The non-spec fallback controls are dormant in the approved auto profile. Fresh collector smoke/full and the bounded native timing gate remain pending; this draft is not publication approval or historical-data reuse approval.
- Limits: uniform verify and unpadded per-layer cache pages, without full-model padding, RecoverSSM or mixed scheduler claims. Immutable serving citations are included in the collector and README.
Signed-off-by: Simone Chen <simonec@nvidia.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
Contributor
Author
|
/ok to test 457689d |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.