Skip to content

ci: support version-routed collector change detection - #592

Closed
simone-chen wants to merge 1 commit into
mainfrom
simonec/fix-ci-version-routes
Closed

simone-chen wants to merge 1 commit into
mainfrom
simonec/fix-ci-version-routes

Conversation

@simone-chen

@simone-chen simone-chen commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor
  • Fix Collector Data CI failing with NotImplementedError when a registry uses VersionRoute, as in the vLLM 0.31 collectors in fix: qualify vLLM 0.31 B200 attention collectors #587.
  • Parse literal positional/keyword routes without importing collector code. Include all route modules and case closures in family change detection, and flag route threshold/order changes as collector_code.
  • Keep unknown or dynamic route syntax fail-closed and retain required hash-closure checks. Document conservative coverage across versions; runtime collector dispatch is unchanged.
  • Validation: 55 focused tests and the clean-tree repository smoke passed (56 total); Ruff passed; real PR fix: qualify vLLM 0.31 B200 attention collectors #587 source successfully produces the changed-operation manifest. Full CI requested for 33902ae02d2be7d76050921e06542066eb56d2cd; GitHub verifies the GPG-signed/DCO commit.

Signed-off-by: Simone Chen <simonec@nvidia.com>
@coderabbitai

coderabbitai Bot commented Oct 26, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@simone-chen

Copy link
Copy Markdown
Contributor Author

/ok to test 33902ae

@simone-chen

Copy link
Copy Markdown
Contributor Author

Closing as outside the requested review scope: retain only attention #604, recurrent/MoE #605, and communication #591 for Tianhao's review. This campaign infrastructure change is not merged or included in the replacements. Its branch and history remain available for separate future work; collection remains stopped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant