Repository navigation
ci: support version-routed collector change detection - #592
Closed
simone-chen wants to merge 1 commit into
Closed
simone-chen wants to merge 1 commit into
simone-chen wants to merge 1 commit into
Conversation
Signed-off-by: Simone Chen <simonec@nvidia.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
Contributor
Author
|
/ok to test 33902ae |
Contributor
Author
|
Closing as outside the requested review scope: retain only attention #604, recurrent/MoE #605, and communication #591 for Tianhao's review. This campaign infrastructure change is not merged or included in the replacements. Its branch and history remain available for separate future work; collection remains stopped. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NotImplementedErrorwhen a registry usesVersionRoute, as in the vLLM 0.31 collectors in fix: qualify vLLM 0.31 B200 attention collectors #587.collector_code.33902ae02d2be7d76050921e06542066eb56d2cd; GitHub verifies the GPG-signed/DCO commit.