Update integration test for model exists but is missing map#169
Open
jules-exel wants to merge 1 commit into
Open
Update integration test for model exists but is missing map#169jules-exel wants to merge 1 commit into
jules-exel wants to merge 1 commit into
Conversation
…ld silent drop Scenario 13 (model exists in target, no mapping) was authored against the pre-PROD-2211 silent-drop behavior (0 mappings) and merged after PROD-2211 landed on main, so the scenario job broke: the model pusher now correctly adopts the existing target model by (referenceName, contentDefinitionTypeID), writes the mapping (source 10 -> target 50), and skips — with no saveModel call. Update the fixture to expect the corrected, self-healing behavior. No production code change; PROD-2211's map-on-adopt is the intended behavior (the old gap was documented as unintended in FINDINGS.md Finding 5). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
jules-exel
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
Scenario testsCI job is failing onmain(run):Root cause
Two merges crossed:
ff0104dPROD-2211 added map-on-adopt: a custom model that already exists on the target by(referenceName, contentDefinitionTypeID)but has no mapping row is now adopted — the pusher writes the mapping and skips (nosaveModel). This fixed the old silent-drop gap (documented as unintended in FINDINGS.md Finding 5).84fb832CLI Integration tests added scenario 13, but its fixture still encoded the old silent-drop expectation (0mappings).So the fixture, not the code, is stale.
Fix
Update
13-model-exists-in-target-no-mapping/scenario.jsonto expect the corrected behavior: 1 mapping (10 → 50), stillsaveModel: 0, and refresh the description. No production code change.npx jest src/tests/sync/sync-scenarios.test.ts --no-coverage→ 16/16 passing.🤖 Generated with Claude Code