fix: align startup banner URL defaults with actual service defaults - #423
Open
chinaux wants to merge 1 commit into
Open
fix: align startup banner URL defaults with actual service defaults#423chinaux wants to merge 1 commit into
chinaux wants to merge 1 commit into
Conversation
Member
|
Thank you for identifying and addressing this issue! The underlying problem was valid, but it has since been resolved more comprehensively in #453, which uses the instantiated service values for the resolved host, port, and MCP transport, and also adds test coverage. Since #453 has already been merged, this PR is now superseded. Thanks again for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The startup banner in
reme/utils/logo_utils.pywas using hard-coded defaults (localhost,8000) when rendering the service URL forhttpandmcp(non-stdio) backends. These defaults did not match the actual service defaults defined inreme/constants.py(REME_DEFAULT_HOST,REME_DEFAULT_PORT), so the banner could display a misleading URL when the user relied on the default configuration.This PR aligns the banner URL defaults with the real service defaults by importing
REME_DEFAULT_HOSTandREME_DEFAULT_PORTfromreme.constants.Changes
reme/utils/logo_utils.py:REME_DEFAULT_HOSTandREME_DEFAULT_PORT.hostandportin bothhttpandmcp(non-stdio) branches.Motivation
When starting the ReMe HTTP service without explicitly setting
host/port, the banner previously showedhttp://localhost:8000even though the actual listening address might default to a different host/port (as defined inreme.constants). This can confuse users who copy the URL from the banner.