Repository navigation
rlf-codex-rl 5.8:gate 磁带收集器同时接受 rl_trajectory_reward 事件(ports 引擎关键修复) - #235
Merged
Merged
Conversation
rlf-codex-rl 5.8 attempt 8 lesson: the ports launcher binds --rollout-all-samples-process-path to rollout_meta_hook.extract_rollout_metadata, so the legacy queue_completed_groups hook (054c20d5) never runs there and the tape carried zero rl_sample_outcome events. The meta hook already reports per-sample task_id/reward/success which the driver tapes as rl_trajectory_reward behind --rl-observe-timeline; teach the gate collector to accept both event shapes (sample_index fills index), same fail-closed rules. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
范围与动机
-9 gate 跑的关键修复。-8 跑发现:ports launcher 把
--rollout-all-samples-process-path绑定到rollout_meta_hook.extract_rollout_metadata,导致 #234 中 legacyqueue_completed_groups的_emit_sample_outcomeshook 在 ports 下从不执行,磁带上零个rl_sample_outcome事件,gate 拿不到样本级证据。而 meta hook 本身已上报 per-sample 的 task_id/reward/success,driver 侧在
--rl-observe-timeline下会记为rl_trajectory_reward磁带事件。本 PR 教 gate 收集器同时接受两种事件形态(rl_trajectory_reward的sample_index填充 index),fail-closed 规则不变(缺数值 reward 跳过、磁带空洞拒绝)。对应 openspec change:
rlf-codex-rl(任务 5.8,attempt 8 教训)。测试证据
新增 2 个用例:
rl_trajectory_reward事件被收集(sample_index 填位)、与rl_sample_outcome混收判定。依赖关系
rlf-pr5-tape-outcomes(rlf-codex-rl 5.8:样本级 reward/success 上事件磁带,gate 从磁带收集 outcome #234)——直接改 rlf-codex-rl 5.8:样本级 reward/success 上事件磁带,gate 从磁带收集 outcome #234 落地的收集器与其测试;合并顺序:rlf-codex-rl 核心:trusted flag、Qwen3-30B-A3B profile、RLF 入口接线与 baseline runner #230 → rlf-codex-rl 5.8:RL gate 判定器 rlf_rl_gate + 证据链 + attempt-1 教训 #231 → rlf-codex-rl 5.8:--rl-training-attention-backend 与 --session-server-workers 两个训练侧 flag #233 → rlf-codex-rl 5.8:样本级 reward/success 上事件磁带,gate 从磁带收集 outcome #234 → 本 PRMade with Cursor