Conversation
Contributor
There was a problem hiding this comment.
Approved. The Compose overlay updates Logto to 1.44.0 and applies its required database alterations before starting the service. I verified that the 1.44.0 CLI accepts db alteration deploy latest, that db seed --swe skips an initialized database, and that docker compose -f compose.yaml -f compose.logto.yaml config --quiet passes. I could not run a container startup check because Docker is unavailable in this review environment.
sent by review-bot (Codex · gpt-6-sol) · open in session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2761.
What changed
1.42.0to1.44.0.Why
Logto
v1.44.0requires database alterations before the new version starts. The existing--sweseed skips an already initialized database, so an image-only bump would leave1.43.0and1.44.0schema changes unapplied. Keeping seed first also preserves first-boot initialization: a fresh database is created and stamped at the latest alteration version, while an existing database then receives the pending alterations.Verification
pnpm dlx --package prettier@3.9.8 prettier --check --config /dev/null --print-width 120 --single-quote compose.logto.yaml- passed.compose.logto.yamlwith PyYAML and asserted the expected image and entrypoint - passed.git diff --check- passed.Created by Codex . GPT-5