Repository navigation
feat(agentctl): add exec --json #286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Ridwan Hoq (ridhoq)
wants to merge
1
commit into
agent-primitives:main
Choose a base branch
from
ridhoq:feat/exec-json
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+664
−132
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| category: Compatibility | ||
| --- | ||
|
|
||
| - The human output of `agentctl exec`, `replay` and `fork` is for people and will change in a later | ||
| release. Scripts that parse it should move to `--json`; `exec` now supports it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| --- | ||
| category: Added | ||
| --- | ||
|
|
||
| - `agentctl exec --json` prints the turn as JSON Lines: one protobuf `ExecUpdate` per line as it | ||
| arrives, each a `session` or a committed `record`. The first line is the session, so a script | ||
| learns the UID of a session `exec` created; a turn paused for approval exits successfully and | ||
| ends with a `session` snapshot whose `pending_approval` names the call, unless a concurrent | ||
| approval has already resolved it. Only a recorded `EVENT_END` shows completion. Streamed model | ||
| chunks are left out; the `EVENT_OUTPUT` record carries the complete response. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| category: Fixed | ||
| --- | ||
|
|
||
| - `agentctl exec` no longer exits successfully when writing to stdout fails. It stops writing, reads | ||
| the turn to its end so the turn is not cut short, then exits with an error noting that the turn's | ||
| records are committed. A closed pipe still ends `exec` with SIGPIPE, as before. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: the stream has OUTPUT but no INPUT, so a mutation that drops only INPUT passes both the agentctl and agentsessionsd tests. An INPUT frame in the supplied and expected stream would pin "every committed record". Separately, nothing covers text-mode exec with
--session: settingnewSession: trueat main.go:356 passes every test. A row asserting nosessionline would cover it.