Repository navigation
Check whether the DMG is still mounted instead of trusting detach - #23
Merged
Merged
Conversation
A detach that reports "Resource busy" can still unmount the volume a moment later. Every retry after that failed with "No such file or directory", so the loop gave up and the forced detach failed the build, as it did on #22. Each retry now checks hdiutil info for the mount point and stops once it is gone, and the forced detach runs only if the volume is still mounted. The check captures hdiutil info before searching it, so pipefail cannot misread an early grep exit, and a failed query stops the script. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #20. A detach that reports "Resource busy" can still unmount a moment later, after which every retry fails with "No such file or directory" and the forced detach failed the build.
Evidence
validatefailed withhdiutil: detach failed - No such file or directoryafter ten silent retries.After: stub probes finish with the volume detached when it detaches at once, reports busy and then unmounts, or stays busy (forced). When
hdiutil infofails, the script exits 1.hdiutil info | grep -qunderpipefailcould misreport a mounted volume via SIGPIPE. Fixed by capturing the output first. Round 2 found nothing.Merge Danger
Door: two-way
Blast Radius: packaging
CI and the release workflow both run
package-dmg.sh.🤖 Generated with Claude Code