fix: remove AppService suffix from Angular proxy routes to match ABP dynamic API convention - #281
Merged
Merged
Conversation
…dynamic API convention Co-Authored-By: Afonso Dutra Nogueira Filho <afonsoft@gmail.com>
afonsoft
self-requested a review
August 1, 2026 02:30
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
Contributor
Author
|
E2E validation completed for this PR against the full Docker stack.
No Screen recording and full report available in the test session. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



All Submissions:
Component Type
Description
MassNotification,UserDelegationandOrganizationUnitby removing theAppServicesuffix from the URL path.AppServicepostfix when exposing application services as controllers (MassNotificationAppService→/api/services/app/MassNotification/...). The existing proxy URLs kept theAppServicesegment, which would return404at runtime.New Feature Submissions
dotnet teston the new application-service test suites andnpx ng build --configuration=productionpassed.npx eslinton the three changed files reported only pre-existingno-explicit-anywarnings; formatting fixed withprettier --write.Breaking Changes
Tests executed
dotnet test test/Eaf.Middleware.Application.Tests/Eaf.Middleware.Application.Tests.csproj --filter "FullyQualifiedName~EditionAppServiceBddTests|MassNotificationAppServiceBddTests|PaymentAppServiceBddTests|UserDelegationAppServiceBddTests|OrganizationUnitAppServiceBddTests"npx ng build --configuration=productioninsideTemplates/Angular/Eaf.ProjectName.UILink to Devin session: https://app.devin.ai/sessions/110d778fadb34e778f16bb1d2d386ae7
Requested by: @afonsoft