Skip to content

Add workflow external trigger APIs - #3696

Open
louis4li wants to merge 6 commits into
feature/integratefrom
feat/2026-10-08_external-trigger-apis
Open

louis4li wants to merge 6 commits into
feature/integratefrom
feat/2026-10-08_external-trigger-apis

Conversation

@louis4li

@louis4li louis4li commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Issue

Closes #3695

Scope

  • Add minimal workflow external-trigger upsert and read endpoints.
  • Add scope-checked workflow trigger fire endpoint.
  • Reuse actor-backed ScheduledDispatchApplicationService state and existing scheduled credential injection path.
  • Keep trigger configuration free of raw credential fields and use a deterministic workflow trigger ID.

Verification

  • dotnet build src/platform/Aevatar.GAgentService.Hosting/Aevatar.GAgentService.Hosting.csproj --nologo
  • dotnet test test/Aevatar.GAgentService.Integration.Tests/Aevatar.GAgentService.Integration.Tests.csproj --nologo --filter ScopeWorkflowEndpointsTests (63 passed)
  • bash tools/ci/test_stability_guards.sh
  • bash tools/ci/architecture_guards.sh (blocked by pre-existing NyxID conformance mismatch in ai_messages.proto and MainnetHostBuilderExtensions.cs)
  • Live local endpoint smoke test not rerun for this branch

Notes

  • Existing schedule persistence and runtime credential handling remain the source of truth; no second trigger store was introduced.

Generated with Claude Code.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@louis4li
louis4li requested a review from jason-aelf as a code owner October 8, 2026 09:59

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2ca4994195

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-08T10:02:08.929389Z 2ca4994 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

louis4li and others added 5 commits October 8, 2026 18:48
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@codecov

codecov Bot commented Oct 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 24.76390% with 717 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.22%. Comparing base (ef4abec) to head (104eb92).
⚠️ Report is 116 commits behind head on feature/integrate.

Files with missing lines Patch % Lines
...ules/WorkflowExternalTriggerProvisioningService.cs 1.03% 667 Missing ⚠️
...osting/Endpoints/ScopeWorkflowScheduleEndpoints.cs 81.94% 40 Missing and 10 partials ⚠️
@@                  Coverage Diff                  @@
##           feature/integrate    #3696      +/-   ##
=====================================================
- Coverage              83.47%   83.22%   -0.26%     
=====================================================
  Files                   1710     1717       +7     
  Lines                 198032   199444    +1412     
  Branches               23757    23879     +122     
=====================================================
+ Hits                  165315   165982     +667     
- Misses                 21680    22397     +717     
- Partials               11037    11065      +28     
Flag Coverage Δ
ci 83.22% <24.76%> (-0.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...DependencyInjection/ServiceCollectionExtensions.cs 97.56% <100.00%> (+0.01%) ⬆️
...osting/Endpoints/ScopeWorkflowScheduleEndpoints.cs 84.64% <81.94%> (-1.55%) ⬇️
...ules/WorkflowExternalTriggerProvisioningService.cs 1.03% <1.03%> (ø)

... and 16 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant