Load NyxID recommended skill refs - #3665
Merged
louis4li merged 15 commits intoSep 30, 2026
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a63449f88d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
louis4li
force-pushed
the
feat/2026-09-18_nyxid-recommended-skill-read
branch
from
September 30, 2026 09:26
c66139e to
4e3ffeb
Compare
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace dynamic connected-service endpoint exposure with the recommended-skill inventory, load, and fixed invocation path, and generate missing Ornn skills from NyxID operation contracts. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Keep inventory read-only, require exact recommended refs for document-guided requests, and expose explicit provisioning for missing refs while preserving NyxID as the source of truth. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Keep recommended Ornn skill refs available when channel inventory responses omit them, so reply generation can continue using committed recommended skill references after the latest feature/integrate merge. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Keep Ornn publish failures typed after the rebase and align channel runtime tests with the current registration-key credential and inventory-source behavior. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
louis4li
force-pushed
the
feat/2026-09-18_nyxid-recommended-skill-read
branch
from
September 30, 2026 09:36
4e3ffeb to
067a5bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Closes #3661
Scope
nyxid_load_recommended_skillreader that revalidates sender inventory, loads exact Ornn refs, and verifies manifest digests.Verification
dotnet build agents/Aevatar.GAgents.NyxidChat/Aevatar.GAgents.NyxidChat.csproj --nologodotnet test test/Aevatar.AI.Tests/Aevatar.AI.Tests.csproj --nologo --filter "NyxIdServiceInstanceClientTests|NyxIdConnectedServiceToolSourceTests"dotnet test test/Aevatar.GAgents.ChannelRuntime.Tests/Aevatar.GAgents.ChannelRuntime.Tests.csproj --nologo --filter ChannelNyxIdConnectedServiceInventoryToolSourceTestsbash tools/ci/test_stability_guards.shbash tools/ci/architecture_guards.shrecommended_skill_refs.Notes
Generated with Claude Code.