Improved door landing - #23
Open
codemann8 wants to merge 1 commit into
Open
Conversation
aerinon
reviewed
Feb 18, 2023
| CMP #$34 : bne + ; inroom stairs | ||
| PHA : LDA #$26 : STA $045E : PLA | ||
| + | ||
| } |
Author
There was a problem hiding this comment.
Looks like it. I was wondering why it still works as is and doesn't crash as it is. And then I realized that it's essentially calling HandleIncomingDoorState twice and it's RTLing there. I've amended the commit to include this.
Improved door landing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improved door landing. This works in ALL scenarios EXCEPT ladders. Ladders will now err on the side of overshooting the doorframe, which is better than sometimes too short.