Repository navigation
Measure the fourth side too, so the verdict clears a bottom-docked card - #83
Merged
Merged
Conversation
The HUD overlay insets itself by whatever the furniture is covering on three sides and by a flat 12px on the fourth. Since #79 gave a theme a bottom dock, that fourth side has something under it: on Warroom the verdict panel was drawn 30px behind the tally card and the transcript — the one line on the board that is a command rather than a rendering of a number — was inside it completely. --pad-b could not simply be added to the padding. It is measured against the window, because the page verdict and the view controls have to clear the rung ladder, and the ladder sits below the viewport rather than over it. The overlay is laid out inside the viewport, so reading --pad-b there clears the ladder a second time and lifts the whole bottom stack a ladder higher than the card it only had to clear by a gap. So publish the number the camera already gets — what covers the board, not what is occupied at the foot of the window — as --pad-b-canvas, and read that. The other three sides need no second token: the viewport starts at the top-left corner of the window, so there the two rectangles agree. Measured in Chrome 147 at 1440x760 on 2026-09-13, Warroom, after a probe: before after tally card #hud-verdict 393-514 393-514 597-700 #hud-transcript 670-698 (inside) 557-585 overlay pad-b 12px 125px The default page is untouched: with nothing docked --pad-b-canvas is 0px and the padding stays at 12px, the transcript at 670-698 exactly as before. replay.html gets the same treatment, where the thing below the board is the transport rather than a card. The gauges do not move. The top row is an `auto` row above a `1fr`, so the padding comes out of the gap; at 625px — one pixel above the height where the layout floats and the question stops applying — the overlay already overflows with the old rule and both rules put the bottom stack in the same place. Closes #81
17 of 26 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Target
develop: the normal case for a fix, a chapter, alab change, a typo
develop→main, shipping to the published guidemain, because published advice iscurrently locking readers out or leaving them exposed
What this changes
The HUD overlay insets itself by whatever the furniture is covering on three
sides and by a flat
12pxon the fourth. Since #79 gave a theme a bottom dock,that fourth side has something under it — so on Warroom the verdict panel was
drawn 30px behind the
tallycard and the transcript was inside it completely.The overlay now measures the bottom edge too, against the right rectangle.
--pad-bcould not simply be added to the padding, which is why this is not theone-line
calc()the issue hoped for. It is measured against the window,because the page verdict and the view controls have to clear the rung ladder,
and the ladder sits below the viewport rather than over it. The overlay is
laid out inside the viewport, so reading
--pad-bthere clears the ladder asecond time and lifts the whole bottom stack one ladder higher than the card it
only had to clear by a gap — 50px of dead air on Warroom, and 50px of dead air
on the default page too, where nothing is docked at all.
So this publishes the number the camera is already handed — what covers the
board, rather than what is occupied at the foot of the window — as
--pad-b-canvas, and the overlay reads that. The other three sides need nosecond token: the viewport starts at the top-left corner of the window, so
there the two rectangles agree.
replay.htmlgets the same treatment, wherethe thing below the board is the transport rather than a card.
Closes #81
Kind
What it was measured against
Not advice and not a command, so the advice section is deleted — but the issue
is a claim about pixels, and the fix is another one, so here is what both were
measured against.
Warroom, 1440x760, after
lab-ubuntu → lab-vps :22:The transcript now ends 12px above the card instead of 101px inside it, and the
nc -vz -w 4 100.71.4.3 22 # on lab-ubuntuline is legible.The default page is untouched. With nothing docked
--pad-b-canvasis0px,the padding stays at
12px, and the transcript sits at 670-698 exactly as itdid before:
replay.html, 1440x950, a 27-frame recording made withmake -C lab record:The issue asked whether the padding shoves the gauges on a short window, since
.hud-bottomis the last row of agrid-template-rows: auto 1fr auto. It doesnot: the padding comes out of the
1frrow. A/B at 1440x625 — one pixel abovethe height at which the layout floats and the question stops applying — with the
old rule forced back inline:
At that height the overlay already overflows on
develop, and both rules putthe bottom stack in the same place, so this is neither a fix nor a regression
there.
Checks
make -C lab checkpasses — 49 tests, 0 failuresgofmtis clean (make checkfails on any output at all)SPDX-License-Identifierheader — no new filesIf this touches the guide's pages
Not applicable: this is
lab/control/ui/, which is served by the controlcontainer rather than opened from
file://. Nothing underassets/is touchedand no chapter moved.
If this touches the lab or sandbox engine
measurement, taken off the same rectangle the camera is given
dangerstill outranksokpass/fail
lab/README.mdmoved with it —no score moved; this changes where a panel is drawn, not what it says
Licence
CC BY-SA 4.0 (guide) or GPL-3.0-or-later (code), per the file I touched
Found while doing this, and not in this change
The page verdict pill (
#verdict) is drawn over#hud-transcript. It is notfrom #79 and it is not from this change — it already happens on the default
Chapter page on
develop, where the pill hides the# on lab-ubuntutail ofthe command:
Both are positioned to clear the same furniture by the same amount — the pill by
--pad-b + 10pxagainst the window, the overlay now by--pad-b-canvas + 12pxagainst the board, which work out within 2px of each other at every size. So
they share a lane by construction.
This change puts Warroom into exactly the relationship Chapter already has,
which is what #81 asked for — the issue calls the default page unaffected. It
does not make the pill and the transcript stop overlapping. That is its own
idea and wants its own branch.