Repository navigation
fix(cookies): serialize maxAge of zero as Max-Age=0 - #145
Open
andrewstellman wants to merge 1 commit into
Open
andrewstellman wants to merge 1 commit into
andrewstellman wants to merge 1 commit into
Conversation
serializeCookie used a truthiness check on maxAge, so maxAge: 0 was dropped and the cookie became a session cookie instead of expiring. Treat 0 as a valid value and pass it through to the serializer.
andrewstellman
marked this pull request as ready for review
October 1, 2026 03:19
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
serializeCookiechecksoptions.maxAgefor truthiness, somaxAge: 0emits noMax-Ageattribute and the cookie becomes a session cookie instead of expiring:Fix
Treat
0as a value;undefined,nulland''behave as before.One behaviour change to be aware of: an app whose config sets
cookie: { maxAge: 0 }currently gets session cookies, and after this getsMax-Age=0on every cookie that doesn't set its ownmaxAge.Testing
Found by Quality Playbook, an AI code-review tool, with Claude; I reviewed the change.