test(popover): phase 6 tests for behavior, utils, and a11y#6426
Conversation
|
📚 Branch Preview Links🔍 Gen1 Visual Regression Test ResultsWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
Deployed to Azure Blob Storage: If the changes are expected, update the |
…nd aria snapshots
e91f4a6 to
0f07ed6
Compare
…-only fixtures The a11y run serves Storybook in ci-a11y/build mode, where the dev-only *.test.ts fixture stories are not indexed, so gotoStory hung to timeout in CI. Point the four native-dismissal tests at the published anatomy/modal/nested stories (which exist in every mode) and drop the now-unused render-only fixtures.
Description
Phase 6 (testing) for the Popover migration: play functions for synthetic-input behavior, Playwright tests for native browser dismissal, and unit tests for the shared
core/utils.What's in it
popover.test.ts): synthetic-input behavior. Property defaults and reflection, ARIA (aria-expanded,aria-haspopup="dialog",aria-controls), click-to-toggle, programmatic close-source, modal scroll-lock and backdrop, focus restoration, and failedshowPopover()/showModal()handling.popover.a11y.spec.ts): ARIA-tree snapshots, plus native light-dismiss (which needs trusted input): Escape and outside-click close-source, modal Escape, and a 3-level nested dismissal-ordering test. Native dismissal cannot run in a play function (see docs(testing): test native dismissal in the Playwright spec, not play functions #6474), so it lives here.resolve-trigger,dismissible-stack,transition,deep-contains.Notes
Base is
ruben/popover-migration(now onmain, spectrum-tokens 14.13.1). #6357 (Phase 4+5) is merged, so this diff is the Phase 6 delta only.Related issue(s)
Accessibility testing checklist
aria-expandedtoggling is covered by play functions.