Skip to content

fix: multiple applications of personalization when apply propositions is invoked - #4

Open
vtsaplin wants to merge 1 commit into
mainfrom
bulk
Open

fix: multiple applications of personalization when apply propositions is invoked#4
vtsaplin wants to merge 1 commit into
mainfrom
bulk

Conversation

@vtsaplin

@vtsaplin vtsaplin commented Nov 7, 2024

Copy link
Copy Markdown

… is invoked

sagarsane added a commit to sagarsane/aem-martech that referenced this pull request May 29, 2026
…ental propositionMetadata reference doc (peer-review adobe-rnd#4)

Co-authored-by: Cursor <cursoragent@cursor.com>

ramboz commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Heads-up: a series of fix PRs just merged into main (#20#32) and this branch now has merge conflicts. Notably, #28 addressed the same double-application issue this PR targets, by serializing applyPropositions calls behind a re-entrancy guard with a trailing re-run (see applyPropositions/onDecoratedElement in src/index.js on main, plus the regression test "serializes concurrent proposition applications" in test/personalization-dom.test.js). Worth checking whether this PR is still needed after a rebase — if the guard covers your case, this can likely be closed; if it doesn't, the new test suite (npm test) is a good place to encode the remaining scenario.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants