fix: commit default e2e/config.json for stage e2e tests - #279
Merged
Conversation
The PLP support PR (#267) rewrote the e2e tests to read pdpSku/plpSlug from e2e/config.json, but that path is gitignored and never generated in CI, so every Deploy to Stage run since has failed at the e2e step with "Cannot find module './config.json'". Un-ignore e2e/config.json and commit the default values already documented in docs/CUSTOMIZE.md. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm run e2estep on every run since feature: Adds Category (PLP) support #267 merged (see run 33022323724), withCannot find module './config.json'.e2e/pdp-ssg.e2e.test.jsande2e/plp-ssg.e2e.test.js(added/rewritten in feature: Adds Category (PLP) support #267) readpdpSku/plpSlugfrome2e/config.json, but that path was gitignored and never generated in CI.e2e/config.jsonspecifically and commits the default demo values already documented indocs/CUSTOMIZE.md(pdpSku: ADB177,plpSlug: apparel).Test plan
Build and TestPR check passes (build/lint/unit tests)Deploy to Stagerun passes thenpm run e2estep🤖 Generated with Claude Code