Skip to content

fix: honor client context for all requests - #101

Merged
adlio merged 1 commit into
adlio:mainfrom
dajiaohuang:fix/542-client-context-cancellation-20261022
Oct 23, 2026
Merged

adlio merged 1 commit into
adlio:mainfrom
dajiaohuang:fix/542-client-context-cancellation-20261022

Conversation

@dajiaohuang

Copy link
Copy Markdown
Contributor

Summary

  • Apply the client context centrally before sending requests, so GET, PUT, POST, multipart POST, and DELETE honor cancellation and deadlines.
  • Replace TestWithContext's default-transport round trip with an in-memory synthetic response, and cover cancellation for every request method.

Validation

  • Go 1.21.13: go test -count=1 -run '^(TestWithContext|TestHTTPMethodsHonorClientContext)$' .
  • go build ./...
  • go vet ./...
  • gofmt on changed Go files and git diff --check

The full repository test suite was not run locally under the synthetic-only test boundary. No Trello API, account, credentials, board data, or real HTTP service was used.

@codecov

codecov Bot commented Oct 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.08%. Comparing base (dab0f63) to head (74853ea).
⚠️ Report is 35 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
+ Coverage   73.51%   74.08%   +0.57%     
==========================================
  Files          22       22              
  Lines         857     1092     +235     
==========================================
+ Hits          630      809     +179     
- Misses        195      240      +45     
- Partials       32       43      +11     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@adlio
adlio merged commit 3a8296d into adlio:main Oct 23, 2026
6 checks passed
@adlio adlio mentioned this pull request Oct 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants