Skip to content

fix inspector rough edges - #40

Merged
adh merged 1 commit into
mainfrom
generalized-inspector
Sep 6, 2026
Merged

adh merged 1 commit into
mainfrom
generalized-inspector

Conversation

@adh

@adh adh commented Sep 5, 2026

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI lite review requested due to automatic review settings September 5, 2026 21:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

Only a minor test failure message clarity nit remains; functional changes appear consistent and covered by updated tests.

Pull request overview

This PR smooths out the object inspector experience by improving inspection metadata, expanding method visibility during class inspection, and adding a non-interactive inspection primitive for scripting/debug output.

Changes:

  • Add ListTalk:inspect* to print an inspection without entering the interactive inspector, and bind both inspect and inspect* in REPL/debugger environments.
  • Update LT_Object_inspection_with_contents to prefer an object’s documentation protocol for inspection descriptions when available.
  • Expand class method inspection to include inherited methods and adjust class inspection naming/description, with corresponding test updates.
File summaries
File Description
tests/listtalk_cli_test.py Updates REPL binding test to assert both inspect and inspect* are present.
tests/c_api_test.c Adds/updates C API expectations for inspection description and class inspection contents.
src/debugger/debugger.c Introduces inspect* and centralizes binding of inspect primitives into environments.
src/classes/Object.c Uses documentation protocol to populate inspection descriptions when implemented.
src/classes/Class.c Includes inherited methods in class method inspection and refines inspection metadata.
Review details
  • Files reviewed: 5/5 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@adh
adh merged commit e92b618 into main Sep 6, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants