fix inspector rough edges - #40
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Only a minor test failure message clarity nit remains; functional changes appear consistent and covered by updated tests.
Pull request overview
This PR smooths out the object inspector experience by improving inspection metadata, expanding method visibility during class inspection, and adding a non-interactive inspection primitive for scripting/debug output.
Changes:
- Add
ListTalk:inspect*to print an inspection without entering the interactive inspector, and bind bothinspectandinspect*in REPL/debugger environments. - Update
LT_Object_inspection_with_contentsto prefer an object’sdocumentationprotocol for inspection descriptions when available. - Expand class method inspection to include inherited methods and adjust class inspection naming/description, with corresponding test updates.
File summaries
| File | Description |
|---|---|
| tests/listtalk_cli_test.py | Updates REPL binding test to assert both inspect and inspect* are present. |
| tests/c_api_test.c | Adds/updates C API expectations for inspection description and class inspection contents. |
| src/debugger/debugger.c | Introduces inspect* and centralizes binding of inspect primitives into environments. |
| src/classes/Object.c | Uses documentation protocol to populate inspection descriptions when implemented. |
| src/classes/Class.c | Includes inherited methods in class method inspection and refines inspection metadata. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.