Collections omissions - #32
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fills in missing collection APIs in ListTalk by adding filter, asVector, size/empty?, and a set of iterator combinators (including a new lazy FilterIterator) along with corresponding tests to prevent regressions.
Changes:
- Added
List>>filter:andLT_List_filter, plusList>>asVectorconversion. - Added
Set>>sizeandSet>>empty?. - Extended
IteratorwithasIterator,map:,filter:,forEach:/do:,any:,every:,inject:into:,reduce:, and introducedFilterIteratorwith VM binding. - Added/expanded tests for the above behaviors (including laziness/consumption semantics).
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/eval-objects.lt | Adds a regression test for Vector>>asVector returning the receiver. |
| tests/eval-collections.lt | Adds coverage for list filtering, list-to-vector conversion, set size/emptiness, and iterator combinators (including lazy map/filter and consuming operations). |
| src/vm/base_env/base_env.c | Registers FilterIterator in the native class bindings so it’s available in the base environment. |
| src/classes/Vector.c | Implements Vector>>asVector as an identity conversion and registers the method. |
| src/classes/Set.c | Implements and registers Set>>size and Set>>empty?. |
| src/classes/List.c | Adds LT_List_filter, List>>filter:, and List>>asVector (with vector allocation/fill). |
| src/classes/Iterator.c | Adds iterator combinators on Iterator and introduces the FilterIterator class implementation. |
| ListTalk/classes/List.h | Exposes LT_List_filter in the public list API. |
| ListTalk/classes/Iterator.h | Declares the new LT_FilterIterator class and constructor. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.