Repository navigation
Add metric/imperial display units to the dashboard - #9
Conversation
Add a metric/imperial preference (default from the browser locale, override in Settings, stored in localStorage) and convert distance, pace and weight for display through shared helpers in lib/format.ts. The API and wire formats stay metric.
|
@johnzanussi thanks for this, super nice addition and it didn't even cross my mind as European, haha. I'll have a look for the app as well, at one point. One change request before I merge: I'prefer metric as the default with imperial as an opt-in. |
|
@aderaaij Ah yes, that make sense. I will get that change in later today. |
Drop the browser-locale guess: en-US is the default language for plenty of people outside the US.
thank you! mind fixing the merge conflict (readme) as well? Thanks. I've submitted the app for beta review btw, so hopefully It'll be in public testflight soon. Will let you know |
# Conflicts: # CHANGELOG.md
|
@aderaaij Done! |
|
@johnzanussi thank you!! TestFlight link for the app is a go: https://testflight.apple.com/join/fV73tucs. Thanks again for checking it out! |
Adds a Metric / Imperial setting so distance, pace and weight can show as mi, min/mi and lb.
lib/format.tsand are used across Overview, Workouts, Workout detail, Health, Plans and Queue.Testing: frontend typecheck, lint and build pass.