Repository navigation
Fix the coach setup instructions found in review of #17 - #18
Merged
Merged
Conversation
Node.js 20 is the minimum for the Claude Desktop path: `npx mcp-remote` always takes the latest release, which depends on undici 7, and that needs Node 20.18.1. The dashboard and the README both said 18. The Claude Code command gains `--scope user`. The default scope registers the server for the folder the command is run in, so running it in the home folder and then opening a project showed no server. In the dashboard the command is also one line now: backslash continuations only work in bash and zsh, and it gets pasted into PowerShell and cmd. Every http address gets --allow-http. mcp-remote exempts only `localhost` and `127.0.0.1`, not `[::1]`, and the flag is harmless on those, so the dashboard no longer mirrors that list. Once a token exists the client choice is locked. The token is named after the client it was created for, and switching afterwards showed another client's setup carrying that name, so the token list misreported what was using it. Another app now means another token. The health test compared the response with the constant the route reads, so it could not fail; it now patches both values. Two CSS rules that .cli-box was overriding take effect, and the client chips report their pressed state.
The client chips locked only once the token existed, so switching client
while the create request was in flight still produced one client's setup
under a token named after another. They now lock from the moment the
request is sent.
With --scope user, running `claude mcp add training` a second time is
refused everywhere ("already exists in user config"), which is exactly
what reconnecting after rotating a token runs into. The dashboard steps
and the README now say to remove the old entry first.
The Node.js minimum is stated as 20.18, which is what mcp-remote's
dependency declares, and the changelog no longer claims the helper was
observed failing on 18.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #17, fixing the non-blocking findings from its independent review.
Changes
npx mcp-remotetakes the latest release (0.16.6), which depends on undici 7, whoseenginesfield requires Node >= 20.18.1.--scope user, in the dashboard and the README. The default scope registers the server only for the folder the command is run in.--allow-http. mcp-remote exempts onlylocalhostand127.0.0.1, sohttp://[::1]was refused; the flag is harmless on localhost.app.routes.health.MCP_ENABLEDto both values..cli-boxwas overriding now apply; client chips carryaria-pressed; a local variable no longer shadows the importedclientLabel.Verification
claude mcp add --helplists--scope; undici'senginesread from the npx cache.[::1], a tailnet http name and an https address: the flag appears on the three http ones only.mcp-remotewith--allow-httpagainsthttp://localhost:8011/mcpconnects and returns the handshake.tsc -bpasses, lint warning count unchanged (14, all pre-existing),tests/test_health.py3 passed.Not verified: the command on Windows shells, and behaviour on Node 18 (the minimum is taken from the dependency's declared requirement).