Repository navigation
fix(server): include fork providers in managed policy - #549
Merged
Merged
Conversation
adampeterhiggins
force-pushed
the
t3code/sync-upstream-20261103-2359
branch
from
November 4, 2026 02:35
3c37d31 to
4be957c
Compare
adampeterhiggins
force-pushed
the
t3code/sync-policy-drivers-20261104
branch
from
November 4, 2026 02:35
dd95806 to
49b9a76
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Managed policy rejected the fork's Devin and Custom ACP drivers because its known-driver registry omitted them. The upstream sync's new all-driver test exposed this pre-existing fork issue.
Register both drivers with their actual settings schemas, preserve Custom ACP's explicit-instance requirement, and lock its launch arguments under a runtime ceiling. Extend the existing ceiling test to cover both drivers.
Parent: #548. Merge the upstream sync first, then this PR.
Validation: captured the failing policy tests before the fix; all 10 focused policy tests pass afterward; formatting/lint pass. Integrated sync-tree validation passed formatting, lint, knip, GraphQL checks, 40 package typechecks and React Compiler coverage. The 236-file test run passed 5,968 tests with one unrelated peer socket fixture failure; that fixture was subsequently replaced by deterministic coverage and all three focused cases pass. Policy-only
check:changedpassed: format, lint, both knip stages, GraphQL, typecheck of 3 affected packages, and both selected test files.Rebased onto the updated sync;
git range-diffconfirms this policy patch is unchanged.Model/harness: GPT-6.1 Sol through the Codex harness.
Manual web regression — November 4
Tested commit
49b9a763ae9c882f6830b6dce05db23f44c18887(sync plus policy follow-up) in the built-in Browser panel, incognito, against isolated worktree.t3state. Used the free Replay provider; no paid agent turns.Passed:
composer menu retained Checkouts / Pull requests / GitHub issues / Repositories tabs. @ file search inserted package.json as a context chip.
No product regression found in these exercised flows. A few stale/incorrect automation locators timed out and were resolved using fresh page state. Clipboard read permission is denied, so Copy thread was checked through its success confirmation rather than clipboard bytes. No remote/tunnel, hosted production build, desktop-native, mobile, live managed-policy deployment, paid-provider turns, or live usage-hub credentials were exercised. This was a focused pass, not exhaustive coverage of 167 commits.