Skip to content

fix(server): include fork providers in managed policy - #549

Merged
adampeterhiggins merged 1 commit into
mainfrom
t3code/sync-policy-drivers-20261104
Nov 4, 2026
Merged

adampeterhiggins merged 1 commit into
mainfrom
t3code/sync-policy-drivers-20261104

Conversation

@adampeterhiggins

@adampeterhiggins adampeterhiggins commented Nov 4, 2026 •

Copy link
Copy Markdown
Owner

Managed policy rejected the fork's Devin and Custom ACP drivers because its known-driver registry omitted them. The upstream sync's new all-driver test exposed this pre-existing fork issue.

Register both drivers with their actual settings schemas, preserve Custom ACP's explicit-instance requirement, and lock its launch arguments under a runtime ceiling. Extend the existing ceiling test to cover both drivers.

Parent: #548. Merge the upstream sync first, then this PR.

Validation: captured the failing policy tests before the fix; all 10 focused policy tests pass afterward; formatting/lint pass. Integrated sync-tree validation passed formatting, lint, knip, GraphQL checks, 40 package typechecks and React Compiler coverage. The 236-file test run passed 5,968 tests with one unrelated peer socket fixture failure; that fixture was subsequently replaced by deterministic coverage and all three focused cases pass. Policy-only check:changed passed: format, lint, both knip stages, GraphQL, typecheck of 3 affected packages, and both selected test files.

Rebased onto the updated sync; git range-diff confirms this policy patch is unchanged.

Model/harness: GPT-6.1 Sol through the Codex harness.

Manual web regression — November 4

Tested commit 49b9a763ae9c882f6830b6dce05db23f44c18887 (sync plus policy follow-up) in the built-in Browser panel, incognito, against isolated worktree .t3 state. Used the free Replay provider; no paid agent turns.

Passed:

  • Pairing and local WebSocket connection; full reload restored the conversation and unsent file mention.
  • Showcase streamed through the real orchestration pipeline, displayed approval, accepted it, and completed with formatted markdown, code and table output. Activity expanded/collapsed.
  • Draft text persisted across Settings and new-thread navigation, with an unsent-draft sidebar indicator.
  • Model picker opened with replay scenarios; new-thread workspace, branch and full-access controls remained available; access menu opened.
  • Provider settings loaded; Add provider retained Devin and Custom ACP alongside upstream providers. No provider account configuration changed.
  • Project exclusion produced a Not server chip and hid matching threads; removing the chip restored them.
  • Settle removed the replay thread from the active list; Un-settle restored it while retaining the draft.
  • Command palette opened with Cmd+K, retained fork actions, and Copy thread reported success.
  • composer menu retained Checkouts / Pull requests / GitHub issues / Repositories tabs. @ file search inserted package.json as a context chip.

  • Clicking that chip opened the real file viewer; Refresh file worked and the file rendered.
  • Cmd+P opened file search; typing > switched to command search.
  • Project-grouped (Boring) sidebar rendered and its header New thread retained the selected project. Restored the original sidebar setting afterward.

No product regression found in these exercised flows. A few stale/incorrect automation locators timed out and were resolved using fresh page state. Clipboard read permission is denied, so Copy thread was checked through its success confirmation rather than clipboard bytes. No remote/tunnel, hosted production build, desktop-native, mobile, live managed-policy deployment, paid-provider turns, or live usage-hub credentials were exercised. This was a focused pass, not exhaustive coverage of 167 commits.

@adampeterhiggins
adampeterhiggins force-pushed the t3code/sync-upstream-20261103-2359 branch from 3c37d31 to 4be957c Compare November 4, 2026 02:35
@adampeterhiggins
adampeterhiggins force-pushed the t3code/sync-policy-drivers-20261104 branch from dd95806 to 49b9a76 Compare November 4, 2026 02:35
Base automatically changed from t3code/sync-upstream-20261103-2359 to main November 4, 2026 17:06
@adampeterhiggins
adampeterhiggins merged commit ac6d686 into main Nov 4, 2026
@adampeterhiggins
adampeterhiggins deleted the t3code/sync-policy-drivers-20261104 branch November 4, 2026 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant