Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6f85cc83e4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (channel->state == SSH_CHANNEL_STATE_CLOSED) { | ||
| ssh_set_error(session, | ||
| SSH_FATAL, | ||
| "Remote channel is closed."); | ||
| return SSH_ERROR; |
There was a problem hiding this comment.
In ssh_channel_read_buffered, the closed-state branch is evaluated before the EOF branch. A normal remote close path sets remote_eof = 1 and may set state = SSH_CHANNEL_STATE_CLOSED when buffers are empty, so this function reports SSH_ERROR (and a fatal error message) instead of SSH_EOF for graceful shutdown. That contradicts this API's contract and causes event-loop/nonblocking callers to mis-handle normal channel termination as a hard failure.
Useful? React with 👍 / 👎.
| ssh_get_log_userdata; | ||
| ssh_get_openssh_version; | ||
| ssh_get_poll_flags; | ||
| ssh_session_handle_poll; |
There was a problem hiding this comment.
This change adds ssh_session_handle_poll to the public API and linker map, but the current ABI manifest (src/ABI/libssh-4.10.0.symbols) is not updated with that symbol. That leaves ABI bookkeeping inconsistent and can break ABI validation or downstream packaging checks that rely on the manifest matching exported public symbols.
Useful? React with 👍 / 👎.
1 participant
No description provided.