Skip to content

fix(chat): stop Owner Official shelf empty flash while loading - #260

Merged
NeilJo-GY merged 1 commit into
mainfrom
fix/owner-pricing-shelf-loading-flash
Oct 30, 2026
Merged

NeilJo-GY merged 1 commit into
mainfrom
fix/owner-pricing-shelf-loading-flash

Conversation

@NeilJo-GY

Copy link
Copy Markdown
Contributor

Summary

  • Opening Owner Settings briefly showed Official with “No models on this price list…” while Refresh status was disabled, even though Host model-catalog?official_shelf=true returns hundreds of rows.
  • Root cause: officialCatalogLoading started false, so the provisional Official provider rendered the empty-shelf copy before status/catalog settled (then correctly switched to tencenttokenplan).
  • Keep the shelf in the loading state until model status + catalog finish; never cache an empty catalog page for the TTL.

Test plan

  • Open Comiclaw → Agent info → Settings: first paint should show … (or settle to BYO), not the empty Official shelf copy
  • After load: Provider includes Official + tencenttokenplan; switching to Official shows the Default model picker
  • Refresh status becomes enabled after load

Made with Cursor

Initial officialCatalogLoading was false, so the provisional Official provider showed "No models on this price list" before status/catalog settled. Keep the shelf busy until both finish, and never cache an empty catalog page.

Co-authored-by: Cursor <cursoragent@cursor.com>
@vercel

vercel Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
interfaze Ready Ready Preview Oct 30, 2026 1:40pm UTC

@NeilJo-GY
NeilJo-GY merged commit 29d0bab into main Oct 30, 2026
3 checks passed
@NeilJo-GY
NeilJo-GY deleted the fix/owner-pricing-shelf-loading-flash branch October 30, 2026 13:42

This branch was successfully deployed

1 active deployment
Preview — e5652fc7 Deployed Oct 30, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant