Repository navigation
fix(tasks): prevent withdrawal from reopening submitted seats - #321
Merged
Merged
Conversation
NeilJo-GY
marked this pull request as ready for review
October 28, 2026 10:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Participants could withdraw after submitting work, reopening a funded seat while Labs still counted the delivery as an outstanding obligation. A replacement could consume the same funded share. Review also found the reverse race: an unconditional late submission could overwrite an already-cancelled participation.
Restrict withdrawals to active/applied records without a submission. Both submission saves and cancellations now compare the observed state atomically. PostgreSQL uses a row lock and Redis uses Lua; losing either race returns HTTP 409 instead of reviving or cancelling delivered work. Existing callers of save_participation retain the default unconditional behavior; the task submit path opts into the conditional save.
Validation:
This prevents new invalid withdrawals and stale submissions. Existing cancelled delivery records need a separate read-only audit before any cleanup. No production data migration is included.