Repository navigation
adopt: drop the flow-state no-op-store warning once the engine gives every imposter a real store (rift#1504) - #333
Merged
Conversation
… before 0.23.0 rift 0.23.0 gives every imposter an in-memory flow store (rift#1504), so the advisory that flowState() logs for an imposter with no store trigger — reads return empty, the engine uses a no-op store — is false on it. The warning now fires only on an engine known to predate that release, and the version alone settles it, so a newer engine costs no definition fetch. The trigger check stays for older engines. Closes #307
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rift 0.23.0 (rift#1504, PR achird-labs/rift#1520) gives every imposter a default in-memory flow store with a 300 s TTL. Before that, an imposter with no
_rift.flowState, no scenario stub, no script stub and nostateOpsgot a no-op store, andImposter.flowState()warned about it. On 0.23.0 that warning is false.The warning is version-gated rather than removed. Engines from 0.13.1 to 0.22.0 still use the no-op store, so it remains true for them.
ImposterImplgets the engine version fromRiftImplthrough a supplier that never throws. It warns only when the version is known and belowDEFAULT_FLOW_STORE_SINCE = "0.23.0". An unknown version, or a dev build below the floor (0.1.0), is not warned about.FlowStateSupport.hasStoreTriggeris unchanged, since older engines still need it. Its docs now say it applies to engines before 0.23.0.Docs:
Imposter.flowStatejavadoc,FlowStateSupportjavadoc, anddocs/design/sdk-api.md(flow-state configuration).Tests
ImposterImplFlowStateWarnTest:0.1.0give no warning and make no definition fetch.FlowStateIT.anImposterWithNoStoreTriggerStillKeepsFlowState(conformance, spawn and embedded lanes, live rift 0.23.0): a trigger-less imposter'sputreads back. This is the engine fact the gate relies on.Verification
Core unit tests pass (1002).
FlowStateITpasses on both lanes against the rift 0.23.0 binary and dylib.rift-scala: no change. The warning is logged in rift-java.
Closes #307
🤖 Generated with Claude Code