Skip to content

feat(creator-keys): emit ProtocolFeeRecipientUpdatedEvent in set_prot…#591

Merged
Chucks1093 merged 1 commit into
accesslayerorg:mainfrom
Bilalishaq7:feat/fee-recipient-log-event
Jul 27, 2026
Merged

feat(creator-keys): emit ProtocolFeeRecipientUpdatedEvent in set_prot…#591
Chucks1093 merged 1 commit into
accesslayerorg:mainfrom
Bilalishaq7:feat/fee-recipient-log-event

Conversation

@Bilalishaq7

Copy link
Copy Markdown
Contributor

closes #561

Summary

  • Implemented ProtocolFeeRecipientUpdatedEvent emission in set_protocol_fee_recipient (creator-keys/src/lib.rs) when an existing protocol fee recipient is updated.
  • Preserved idempotency: no event is emitted if the new recipient matches the currently stored recipient.
  • Added integration test test_set_protocol_fee_recipient_emits_event_on_update in creator-keys/tests/set_protocol_fee_recipient.rs to verify event name, topic index, and payload contents (old_recipient and new_recipient).

Testing

  • cargo fmt --all -- --check
  • cargo clippy --workspace --all-targets -- -D warnings
  • cargo test --workspace

Checklist

  • Linked issue or backlog item (Closes Add structured log event for protocol fee recipient update by admin #561)
  • Added or updated creator-keys unit/integration tests for every changed contract behavior, including failure paths for new or reachable ContractError variants
  • Ran cargo fmt --all -- --check, cargo clippy --workspace --all-targets -- -D warnings, and cargo test --workspace, or explained exactly why a command was not run
  • Reviewed persistent storage changes against docs/storage-key-invariants.md; any storage layout change includes a migration/backward-compatibility note
  • Confirmed event names, topic order, payload field order, and field meanings remain compatible with docs/contract-event-conventions.md, or documented the breaking change and versioning plan
  • Updated docs for any changed public contract interface, read-only method, event schema, storage behavior, fee logic, or deployment workflow
  • Scope stays limited to one contract concern and does not include unrelated formatting, lockfile, generated artifact, or dependency changes

@Chucks1093
Chucks1093 merged commit ed19a7a into accesslayerorg:main Jul 27, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add structured log event for protocol fee recipient update by admin

2 participants