Skip to content

feat: resolve issues 554-557#563

Open
Judekings wants to merge 1 commit into
accesslayerorg:devfrom
Judekings:feat/issues-554-557
Open

feat: resolve issues 554-557#563
Judekings wants to merge 1 commit into
accesslayerorg:devfrom
Judekings:feat/issues-554-557

Conversation

@Judekings

Copy link
Copy Markdown

Issue 557: Add copy-to-clipboard button for creator Stellar address

  • Add FEATURED_CREATOR_STELLAR_ADDRESS constant (demo Stellar public key)
  • Add stellarAddressCopied state for 2-second Copied! feedback
  • Add handleCopyStellarAddress using existing copyTextToClipboard util
  • Render address row with truncated mono display and accessible copy button
  • Button aria-label toggles between 'Copy Stellar address' and 'Stellar address copied'

Issue 556: Add structured debug log for React Query cache miss

  • Import useQueryClient in useCreatorDetail
  • Detect cache miss by checking queryClient.getQueryData before fetch
  • Emit console.debug with { creator_id, cache_status: 'miss', duration_ms }
  • Log is skipped in test environments (NODE_ENV === 'test')

Issue 555: Add unit tests for useFormatXlm hook

  • Create src/hooks/useFormatXlm.ts with formatXlm() and useFormatXlm()
  • 16 tests covering: default 2dp precision, decimal override (0 and 7), thousands separator, zero input, large values without scientific notation, and hook interface stability

Issue 554: Add T keyboard shortcut to open trade panel

  • Add isTradeShortcut() helper (bare T, no modifiers)
  • Stabilise openTradeDialog with useCallback
  • Register keydown listener after openTradeDialog declaration to avoid TS2448 'used before declaration' error
  • Listener respects isEditableShortcutTarget() and cleans up on unmount
  • Document shortcut in README.md

Misc: update .gitignore with snapshots, *.snap, coverage, .nyc_output,
Thumbs.db, and lock files from other package managers

Summary

Testing

  • pnpm lint
  • pnpm build

Checklist

Issue 557: Add copy-to-clipboard button for creator Stellar address
- Add FEATURED_CREATOR_STELLAR_ADDRESS constant (demo Stellar public key)
- Add stellarAddressCopied state for 2-second Copied! feedback
- Add handleCopyStellarAddress using existing copyTextToClipboard util
- Render address row with truncated mono display and accessible copy button
- Button aria-label toggles between 'Copy Stellar address' and 'Stellar address copied'

Issue 556: Add structured debug log for React Query cache miss
- Import useQueryClient in useCreatorDetail
- Detect cache miss by checking queryClient.getQueryData before fetch
- Emit console.debug with { creator_id, cache_status: 'miss', duration_ms }
- Log is skipped in test environments (NODE_ENV === 'test')

Issue 555: Add unit tests for useFormatXlm hook
- Create src/hooks/useFormatXlm.ts with formatXlm() and useFormatXlm()
- 16 tests covering: default 2dp precision, decimal override (0 and 7),
  thousands separator, zero input, large values without scientific notation,
  and hook interface stability

Issue 554: Add T keyboard shortcut to open trade panel
- Add isTradeShortcut() helper (bare T, no modifiers)
- Stabilise openTradeDialog with useCallback
- Register keydown listener after openTradeDialog declaration to avoid
  TS2448 'used before declaration' error
- Listener respects isEditableShortcutTarget() and cleans up on unmount
- Document shortcut in README.md

Misc: update .gitignore with __snapshots__, *.snap, coverage, .nyc_output,
      Thumbs.db, and lock files from other package managers
@drips-wave

drips-wave Bot commented Jul 24, 2026

Copy link
Copy Markdown

@Judekings Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant