Repository navigation
Conversation
Resolve daemon hooks through native client titles and verified full thread/session IDs instead of inherited TMUX_PANE. Keep embedded clients bound to their ancestor TTY and skip ambiguous or stale targets. Register tmux servers at plugin bootstrap, migrate Codex hooks during installation, and document the required title configuration. Cover routing with isolated tmux/WebSocket tests and two real Codex 0.164.0 clients; retain manual lifecycle checks before release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codex's shared app-server inherits the first client's
TMUX_PANE, so a turn finishing in another pane can style the wrong pane. Route hooks through the live native TUI title, confirm the full thread ID and session tree via read-only local daemon API calls, and pass the explicit tmux socket/pane to the existing state script. Embedded clients use the nearest native Codex ancestor's TTY.Keep the limits test on its original Go module cache while it isolates HOME, avoiding read-only module cleanup failures on Linux.
The installer builds the adapter and migrates this plugin's old hooks without changing foreign hooks or title settings. Shared-daemon users must configure
[tui] terminal_title = ["app-name", "thread-id"], restart clients, reload the plugin in every tmux server, and trust the installed hooks. Missing, stale, ambiguous, or unverifiable targets leave styles unchanged.Stacked on #16 (
agent/add-notification-panel); retarget tomainafter it merges.Validation
./tests/run-all.sh— passed, including routing, idempotent installer migration/uninstall, state transitions, focus resets, panel, and animation.bash -n agent-indicator.tmux scripts/*.sh install.sh setup.sh tests/*.sh tests/lib/*.sh— passed.shellcheck -x -S warning agent-indicator.tmux scripts/*.sh install.sh setup.sh tests/*.sh tests/lib/*.sh— passed.env -u GOROOT go vet ./cmd/codex-hook— passed.env -u GOROOT go test -race ./cmd/codex-hook— passed.python3 tests/test-codex-hook-native.py "$HOME/.codex/packages/app-server-daemon/current/bin/codex"— passed with Codex 0.164.0: two real clients, one scratch daemon/cwd, production adapter with real API and synthetic hook payloads, all four states, duplicate/replaced/stale titles, false full session sharing the truncated prefix.No inference requests or changes to user configuration, installed hooks, or live sessions. Automated assertions cover style isolation; no manual UX screenshots have been captured yet.
Before release
The adapter supports the default local control socket. Remote/custom endpoints and separate
CODEX_HOMEinstances containing copied thread IDs are outside its supported configuration. Hook session IDs identify a session tree, so background descendants cannot be distinguished from the displayed thread within that tree. Details and reproducible checks:docs/CODEX-DAEMON-PANE-BINDING.md.