Repository navigation
Fix done pane focus reset - #15
Merged
Merged
Conversation
accessd
marked this pull request as ready for review
August 14, 2026 11:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Focusing one done pane cleared
PENDING_RESETfor every done pane in the window while resetting only the focused pane's background. A sibling pane could remain green with no state marker left to clear it on later focus.The regression appeared after pane styling moved from
select-pane -Pto pane-scopedset-option -p. The old focus side effect happened to recreate each pane's pending reset marker after the window-wide cleanup.Impact
Each done pane now keeps its deferred background until it receives focus, then resets to the default background.
Validation
./tests/run-all.shbash -n agent-indicator.tmux scripts/*.sh install.sh setup.shshellcheck scripts/pane-focus-in.sh tests/test-focus-reset-done.shgit diff --check