Skip to content

Render diagnostics and update deprecated GitHub Actions runtimes, bump to 0.2.1 - #16

Merged
FreyJo merged 5 commits into
acados:masterfrom
FreyJo:dev26
Jul 31, 2026
Merged

FreyJo merged 5 commits into
acados:masterfrom
FreyJo:dev26

Conversation

@FreyJo

@FreyJo FreyJo commented Jul 31, 2026

Copy link
Copy Markdown
Member
  • Rendering error diagnostics

    • Added explicit extraction/reporting of missing context keys from Tera render errors.
    • On missing variables/fields, the CLI now emits a targeted message naming the missing key and template.
    • Replaced panic-prone context creation (unwrap) with structured error propagation for invalid JSON/context serialization failures.
  • CI runtime deprecation cleanup

    • Updated workflow actions to remove Node.js 20 deprecation warnings: update checkout and upload-artifact from v4 to v5
  • remove outdated travis CI

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Improves CLI diagnostics around Tera rendering failures (especially missing context keys) and cleans up CI configuration by removing Travis and updating GitHub Actions to newer major versions.

Changes:

  • Add parsing helpers to extract missing context keys from tera::Error and print a targeted missing-key message on render failures.
  • Replace panic-prone context construction (unwrap) with io::Error-based propagation for invalid JSON and serialization failures.
  • Remove .travis.yml and bump actions/checkout / actions/upload-artifact to @v5 in the GitHub Actions workflow.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/main.rs Adds missing-context diagnostics and replaces unwrap with structured error propagation.
.travis.yml Removes obsolete Travis CI configuration.
.github/workflows/main.yml Updates Actions to newer major versions to address runtime deprecation warnings.
Suppressed comments (1)

src/main.rs:72

  • The context-serialization error message omits the JSON file path. Including json_file would make this failure easier to diagnose from CLI output.
        io::Error::new(
            io::ErrorKind::InvalidData,
            format!("Failed to build template context from JSON: {}", e),
        )
    })?;

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/main.rs Resolved
@FreyJo
FreyJo force-pushed the dev26 branch 2 times, most recently from c9b9a13 to 65ae4b4 Compare July 31, 2026 10:09
@FreyJo FreyJo changed the title Missing-context render diagnostics and update deprecated GitHub Actions runtimes Render diagnostics and update deprecated GitHub Actions runtimes, bump to 0.2.1 Jul 31, 2026
@FreyJo
FreyJo merged commit a480a64 into acados:master Jul 31, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants