Repository navigation
Render diagnostics and update deprecated GitHub Actions runtimes, bump to 0.2.1 - #16
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Improves CLI diagnostics around Tera rendering failures (especially missing context keys) and cleans up CI configuration by removing Travis and updating GitHub Actions to newer major versions.
Changes:
- Add parsing helpers to extract missing context keys from
tera::Errorand print a targeted missing-key message on render failures. - Replace panic-prone context construction (
unwrap) withio::Error-based propagation for invalid JSON and serialization failures. - Remove
.travis.ymland bumpactions/checkout/actions/upload-artifactto@v5in the GitHub Actions workflow.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/main.rs | Adds missing-context diagnostics and replaces unwrap with structured error propagation. |
| .travis.yml | Removes obsolete Travis CI configuration. |
| .github/workflows/main.yml | Updates Actions to newer major versions to address runtime deprecation warnings. |
Suppressed comments (1)
src/main.rs:72
- The context-serialization error message omits the JSON file path. Including
json_filewould make this failure easier to diagnose from CLI output.
io::Error::new(
io::ErrorKind::InvalidData,
format!("Failed to build template context from JSON: {}", e),
)
})?;
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
FreyJo
force-pushed
the
dev26
branch
2 times, most recently
from
July 31, 2026 10:09
c9b9a13 to
65ae4b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rendering error diagnostics
unwrap) with structured error propagation for invalid JSON/context serialization failures.CI runtime deprecation cleanup
checkoutandupload-artifactfrom v4 to v5remove outdated travis CI