Skip to content

SYN-39 - Complete the pin maps of 22 parts that cannot be exported for fabrication #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SammyOina merged 13 commits into from
Nov 2, 2026
Merged

SYN-39 - Complete the pin maps of 22 parts that cannot be exported for fabrication #195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
7f0a7d6
fix(registry): the JST connectors recorded a pad's size as the package's
JeffMboya Oct 15, 2026
0110dca
fix(registry): the crystals' second terminal was a grounded case pad
JeffMboya Oct 15, 2026
eba9095
fix(registry): declare the copper pads sixteen parts left out
JeffMboya Oct 15, 2026
53fb11f
fix(registry): point the W5500's decoupling requirement at the pin it…
JeffMboya Oct 20, 2026
b129241
fix(fixtures): follow the W5500's vcc rename into the three fixtures …
JeffMboya Oct 21, 2026
43c4cf8
fix(registry): say where the EEPROM pin maps came from, and stop the …
rodneyosodo Oct 30, 2026
f80a3a3
test(place): re-record the feather placement after rebasing onto main
rodneyosodo Oct 30, 2026
617d9b2
test(kicad): record the two schematic fingerprints CI rendered after …
rodneyosodo Oct 30, 2026
dc790e9
feat(registry): let a part declare a pad the symbol does not have
JeffMboya Oct 21, 2026
52adddd
fix(registry): address PR #195 review (w5500, mcp23017, mpu6050 ep, x…
rodneyosodo Nov 2, 2026
5ad9d30
style: apply rustfmt
rodneyosodo Nov 2, 2026
85300bd
test(kicad): refresh golden fingerprints to CI renderer
rodneyosodo Nov 2, 2026
4a510c2
test(kicad): use CI renderer golden fingerprints
rodneyosodo Nov 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions crates/synth-ir/src/test_support.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ pub fn pin_with(
electrical_type,
capabilities: caps.to_vec(),
required: false,
footprint_only: false,
unit: None,
voltage_max_v: None,
voltage_min_v: None,
Expand Down
1 change: 1 addition & 0 deletions crates/synth-kicad/src/multisheet.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,6 +374,7 @@ mod tests {
electrical_type: ElectricalType::Passive,
capabilities: Vec::new(),
required: false,
footprint_only: false,
unit: None,
voltage_max_v: None,
voltage_min_v: None,
Expand Down
2 changes: 2 additions & 0 deletions crates/synth-kicad/src/pcb.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2930,6 +2930,7 @@ mod tests {
electrical_type: ElectricalType::PowerInput,
capabilities: vec![],
required: true,
footprint_only: false,
unit: None,
voltage_max_v: None,
voltage_min_v: None,
Expand All @@ -2941,6 +2942,7 @@ mod tests {
electrical_type: ElectricalType::PowerInput,
capabilities: vec![],
required: true,
footprint_only: false,
unit: None,
voltage_max_v: None,
voltage_min_v: None,
Expand Down
1 change: 1 addition & 0 deletions crates/synth-kicad/src/schem_erc.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1626,6 +1626,7 @@ mod tests {
electrical_type: synth_registry::ElectricalType::Bidirectional,
capabilities: Vec::new(),
required: false,
footprint_only: false,
unit: None,
voltage_max_v: None,
voltage_min_v: None,
Expand Down
4 changes: 4 additions & 0 deletions crates/synth-kicad/src/symbol_lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -684,6 +684,7 @@ mod tests {
electrical_type,
capabilities,
required: false,
footprint_only: false,
unit: None,
voltage_max_v: None,
voltage_min_v: None,
Expand Down Expand Up @@ -757,6 +758,7 @@ mod tests {
electrical_type: ElectricalType::Bidirectional,
capabilities: vec![],
required: false,
footprint_only: false,
unit: None,
voltage_max_v: None,
voltage_min_v: None,
Expand All @@ -768,6 +770,7 @@ mod tests {
electrical_type: ElectricalType::PowerInput,
capabilities: vec![],
required: true,
footprint_only: false,
unit: None,
voltage_max_v: None,
voltage_min_v: None,
Expand Down Expand Up @@ -883,6 +886,7 @@ mod tests {
electrical_type: ElectricalType::PowerInput,
capabilities: vec![],
required: true,
footprint_only: false,
unit: None,
voltage_max_v: None,
voltage_min_v: None,
Expand Down
2 changes: 2 additions & 0 deletions crates/synth-kicad/tests/schem_erc.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,7 @@ fn part(kind: &str) -> Part {
electrical_type: synth_registry::ElectricalType::Passive,
capabilities: Vec::new(),
required: false,
footprint_only: false,
unit: None,
voltage_max_v: None,
voltage_min_v: None,
Expand All @@ -128,6 +129,7 @@ fn part(kind: &str) -> Part {
electrical_type: synth_registry::ElectricalType::Passive,
capabilities: Vec::new(),
required: false,
footprint_only: false,
unit: None,
voltage_max_v: None,
voltage_min_v: None,
Expand Down
1 change: 1 addition & 0 deletions crates/synth-knowledge/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -992,6 +992,7 @@ mod tests {
electrical_type: t,
capabilities: vec![],
required: false,
footprint_only: false,
unit: None,
voltage_max_v: None,
voltage_min_v: None,
Expand Down
7 changes: 7 additions & 0 deletions crates/synth-layout/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6556,6 +6556,7 @@ mod semantic_weights_tests {
electrical_type: et,
capabilities: Vec::new(),
required: false,
footprint_only: false,
unit: None,
voltage_max_v: None,
voltage_min_v: None,
Expand Down Expand Up @@ -6891,6 +6892,7 @@ mod soft_pin_swap_tests {
electrical_type: et,
capabilities: caps.to_vec(),
required: false,
footprint_only: false,
unit: None,
voltage_max_v: None,
voltage_min_v: None,
Expand Down Expand Up @@ -7140,6 +7142,7 @@ mod patterns_tests {
electrical_type: et,
capabilities: caps.to_vec(),
required: false,
footprint_only: false,
unit: None,
voltage_max_v: None,
voltage_min_v: None,
Expand Down Expand Up @@ -7900,6 +7903,7 @@ mod text_width_tests {
electrical_type: ElectricalType::Passive,
capabilities: Vec::new(),
required: false,
footprint_only: false,
unit: None,
voltage_max_v: None,
voltage_min_v: None,
Expand All @@ -7911,6 +7915,7 @@ mod text_width_tests {
electrical_type: ElectricalType::Passive,
capabilities: Vec::new(),
required: false,
footprint_only: false,
unit: None,
voltage_max_v: None,
voltage_min_v: None,
Expand Down Expand Up @@ -8480,6 +8485,7 @@ mod naming_tests {
electrical_type: et,
capabilities: caps.to_vec(),
required: false,
footprint_only: false,
unit: None,
voltage_max_v: None,
voltage_min_v: None,
Expand Down Expand Up @@ -8784,6 +8790,7 @@ mod documentation_tests {
electrical_type: ElectricalType::Passive,
capabilities: Vec::new(),
required: false,
footprint_only: false,
unit: None,
voltage_max_v: None,
voltage_min_v: None,
Expand Down
6 changes: 6 additions & 0 deletions crates/synth-layout/src/route/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2636,6 +2636,7 @@ mod channel_router_tests {
electrical_type: ElectricalType::Passive,
capabilities: Vec::new(),
required: false,
footprint_only: false,
unit: None,
voltage_max_v: None,
voltage_min_v: None,
Expand All @@ -2647,6 +2648,7 @@ mod channel_router_tests {
electrical_type: ElectricalType::Passive,
capabilities: Vec::new(),
required: false,
footprint_only: false,
unit: None,
voltage_max_v: None,
voltage_min_v: None,
Expand Down Expand Up @@ -2923,6 +2925,7 @@ mod drc_tests {
electrical_type: ElectricalType::Passive,
capabilities: Vec::new(),
required: false,
footprint_only: false,
unit: None,
voltage_max_v: None,
voltage_min_v: None,
Expand All @@ -2934,6 +2937,7 @@ mod drc_tests {
electrical_type: ElectricalType::Passive,
capabilities: Vec::new(),
required: false,
footprint_only: false,
unit: None,
voltage_max_v: None,
voltage_min_v: None,
Expand Down Expand Up @@ -3152,6 +3156,7 @@ mod net_termination_tests {
electrical_type: ElectricalType::Passive,
capabilities: Vec::new(),
required: false,
footprint_only: false,
unit: None,
voltage_max_v: None,
voltage_min_v: None,
Expand All @@ -3163,6 +3168,7 @@ mod net_termination_tests {
electrical_type: ElectricalType::Passive,
capabilities: Vec::new(),
required: false,
footprint_only: false,
unit: None,
voltage_max_v: None,
voltage_min_v: None,
Expand Down
2 changes: 2 additions & 0 deletions crates/synth-layout/src/sheets.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,6 +450,7 @@ mod tests {
electrical_type: ElectricalType::Passive,
capabilities: Vec::new(),
required: false,
footprint_only: false,
unit: None,
voltage_max_v: None,
voltage_min_v: None,
Expand Down Expand Up @@ -881,6 +882,7 @@ mod tests {
electrical_type: Et::PowerInput,
capabilities: Vec::new(),
required: false,
footprint_only: false,
unit: None,
voltage_max_v: None,
voltage_min_v: None,
Expand Down
2 changes: 2 additions & 0 deletions crates/synth-layout/tests/channel_router.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ fn two_pin_part() -> Part {
electrical_type: ElectricalType::Passive,
capabilities: Vec::new(),
required: false,
footprint_only: false,
unit: None,
voltage_max_v: None,
voltage_min_v: None,
Expand All @@ -41,6 +42,7 @@ fn two_pin_part() -> Part {
electrical_type: ElectricalType::Passive,
capabilities: Vec::new(),
required: false,
footprint_only: false,
unit: None,
voltage_max_v: None,
voltage_min_v: None,
Expand Down
1 change: 1 addition & 0 deletions crates/synth-layout/tests/label_spots.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ fn pin(name: &str) -> Pin {
electrical_type: ElectricalType::Passive,
capabilities: Vec::new(),
required: false,
footprint_only: false,
unit: None,
voltage_max_v: None,
voltage_min_v: None,
Expand Down
1 change: 1 addition & 0 deletions crates/synth-layout/tests/naming.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ fn pin(name: &str, caps: &[PinCapability]) -> RegPin {
electrical_type: ElectricalType::Bidirectional,
capabilities: caps.to_vec(),
required: false,
footprint_only: false,
unit: None,
voltage_max_v: None,
voltage_min_v: None,
Expand Down
1 change: 1 addition & 0 deletions crates/synth-layout/tests/semantic_placement.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ fn pin(name: &str, et: ElectricalType) -> Pin {
electrical_type: et,
capabilities: Vec::new(),
required: false,
footprint_only: false,
unit: None,
voltage_max_v: None,
voltage_min_v: None,
Expand Down
110 changes: 55 additions & 55 deletions crates/synth-place/tests/snapshots/snapshots__feather_m4_express_placement.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,67 +2,67 @@
source: crates/synth-place/tests/snapshots.rs
expression: snapshot
---
board_outline_mm: 72.07 x 46.77
board_outline_mm: 72.07 x 47.27

U1 ( 36.30, 23.73) mm rot=Zero layer=Top
U2 ( 19.80, 20.73) mm rot=Zero layer=Top
U3 ( 52.80, 17.23) mm rot=Zero layer=Top
U1 ( 35.80, 23.73) mm rot=Zero layer=Top
U2 ( 19.30, 20.73) mm rot=Zero layer=Top
U3 ( 52.80, 17.73) mm rot=Zero layer=Top
U4 ( 52.80, 26.73) mm rot=Zero layer=Top
U5 ( 55.30, 33.23) mm rot=Zero layer=Top
U6 ( 52.80, 37.73) mm rot=Zero layer=Top
U7 ( 56.30, 41.23) mm rot=Zero layer=Top
U8 ( 52.80, 41.23) mm rot=Zero layer=Top
U9 ( 49.30, 41.23) mm rot=Zero layer=Top
J1 ( 19.80, 8.73) mm rot=OneEighty layer=Top
U5 ( 56.80, 33.73) mm rot=Zero layer=Top
U6 ( 50.80, 36.73) mm rot=Zero layer=Top
U7 ( 52.80, 41.73) mm rot=Zero layer=Top
U8 ( 48.80, 41.73) mm rot=Zero layer=Top
U9 ( 56.30, 41.73) mm rot=Zero layer=Top
J1 ( 19.30, 8.73) mm rot=OneEighty layer=Top
J2 ( 17.30, 28.23) mm rot=TwoSeventy layer=Top
J3 ( 8.30, 30.73) mm rot=TwoSeventy layer=Top
J4 ( 6.80, 19.23) mm rot=Zero layer=Top
J4 ( 6.30, 19.23) mm rot=Zero layer=Top
J5 ( 66.30, 23.73) mm rot=Zero layer=Top
Y1 ( 8.30, 8.73) mm rot=Zero layer=Top
SW1 ( 40.80, 35.23) mm rot=Zero layer=Top
SW2 ( 32.30, 10.73) mm rot=Ninety layer=Top
C1 ( 24.80, 25.73) mm rot=Zero layer=Top
C2 ( 26.80, 20.23) mm rot=Zero layer=Top
Y1 ( 7.80, 8.73) mm rot=Zero layer=Top
SW1 ( 40.30, 35.23) mm rot=Zero layer=Top
SW2 ( 31.80, 10.73) mm rot=Ninety layer=Top
C1 ( 24.30, 25.73) mm rot=Zero layer=Top
C2 ( 26.30, 20.73) mm rot=Zero layer=Top
C3 ( 32.80, 32.73) mm rot=Zero layer=Top
D1 ( 37.80, 14.73) mm rot=Zero layer=Top
D2 ( 37.80, 12.73) mm rot=Zero layer=Top
D3 ( 58.00, 25.00) mm rot=Zero layer=Top
D4 ( 41.00, 11.50) mm rot=Zero layer=Top
D1 ( 37.30, 14.73) mm rot=Zero layer=Top
D2 ( 37.30, 12.73) mm rot=Zero layer=Top
D3 ( 58.00, 25.50) mm rot=Zero layer=Top
D4 ( 40.50, 11.50) mm rot=Zero layer=Top
D5 ( 26.50, 31.00) mm rot=Zero layer=Top
D6 ( 42.30, 15.23) mm rot=Zero layer=Top
D7 ( 27.00, 34.50) mm rot=Zero layer=Top
R1 ( 30.30, 4.73) mm rot=Zero layer=Top
R2 ( 6.30, 12.23) mm rot=OneEighty layer=Top
R3 ( 48.30, 32.73) mm rot=Zero layer=Top
R4 ( 42.80, 39.73) mm rot=Zero layer=Top
R5 ( 47.50, 28.50) mm rot=OneEighty layer=Top
D6 ( 40.00, 8.00) mm rot=Zero layer=Top
D7 ( 26.50, 35.00) mm rot=Zero layer=Top
R1 ( 29.80, 4.73) mm rot=Zero layer=Top
R2 ( 5.80, 12.23) mm rot=OneEighty layer=Top
R3 ( 40.80, 39.73) mm rot=Zero layer=Top
R4 ( 33.30, 35.23) mm rot=Zero layer=Top
R5 ( 29.00, 32.50) mm rot=OneEighty layer=Top
R6 ( 23.30, 31.73) mm rot=Zero layer=Top
R7 ( 58.00, 23.50) mm rot=OneEighty layer=Top
R8 ( 41.00, 13.00) mm rot=Zero layer=Top
R7 ( 58.00, 24.00) mm rot=OneEighty layer=Top
R8 ( 40.50, 13.00) mm rot=Zero layer=Top
R9 ( 26.00, 27.50) mm rot=Zero layer=Top
R10 ( 42.30, 9.73) mm rot=Zero layer=Top
R11 ( 27.80, 36.23) mm rot=Zero layer=Top
R12 ( 36.30, 39.73) mm rot=Zero layer=Top
R13 ( 37.30, 8.73) mm rot=Zero layer=Top
R14 ( 31.80, 39.73) mm rot=Zero layer=Top
R15 ( 23.80, 35.23) mm rot=Zero layer=Top
R16 ( 46.80, 9.73) mm rot=Zero layer=Top
R17 ( 26.80, 39.73) mm rot=Zero layer=Top
R18 ( 18.30, 32.73) mm rot=Zero layer=Top
C4 ( 51.80, 10.73) mm rot=Zero layer=Top
C5 ( 22.30, 38.73) mm rot=Zero layer=Top
C6 ( 18.80, 34.73) mm rot=Zero layer=Top
C7 ( 51.80, 7.23) mm rot=Zero layer=Top
C8 ( 55.80, 11.23) mm rot=Zero layer=Top
C9 ( 17.30, 38.73) mm rot=Zero layer=Top
C10 ( 60.30, 27.73) mm rot=Zero layer=Top
C11 ( 60.30, 20.23) mm rot=Zero layer=Top
C12 ( 60.30, 16.73) mm rot=Zero layer=Top
C13 ( 60.80, 13.23) mm rot=Zero layer=Top
C14 ( 63.30, 32.73) mm rot=Zero layer=Top
C15 ( 60.80, 9.73) mm rot=Zero layer=Top
C16 ( 55.80, 7.73) mm rot=Zero layer=Top
C17 ( 12.80, 38.73) mm rot=Zero layer=Top
C18 ( 63.30, 36.23) mm rot=Zero layer=Top
C19 ( 62.30, 39.73) mm rot=Zero layer=Top
C20 ( 65.30, 15.73) mm rot=Zero layer=Top
R10 ( 41.80, 9.73) mm rot=Zero layer=Top
R11 ( 27.80, 36.73) mm rot=Zero layer=Top
R12 ( 36.80, 8.73) mm rot=Zero layer=Top
R13 ( 56.00, 40.00) mm rot=Zero layer=Top
R14 ( 49.00, 23.00) mm rot=Zero layer=Top
R15 ( 32.30, 40.23) mm rot=Zero layer=Top
R16 ( 60.30, 20.73) mm rot=Zero layer=Top
R17 ( 49.80, 11.23) mm rot=OneEighty layer=Top
R18 ( 63.80, 32.73) mm rot=Zero layer=Top
C4 ( 23.30, 35.73) mm rot=Zero layer=Top
C5 ( 27.30, 40.23) mm rot=Zero layer=Top
C6 ( 46.80, 7.73) mm rot=Zero layer=Top
C7 ( 17.80, 32.73) mm rot=Zero layer=Top
C8 ( 22.80, 39.23) mm rot=Zero layer=Top
C9 ( 18.30, 35.23) mm rot=Zero layer=Top
C10 ( 17.80, 39.23) mm rot=OneEighty layer=Top
C11 ( 54.80, 11.23) mm rot=Zero layer=Top
C12 ( 51.80, 7.73) mm rot=Zero layer=Top
C13 ( 60.30, 17.23) mm rot=Zero layer=Top
C14 ( 60.30, 13.73) mm rot=Zero layer=Top
C15 ( 59.30, 10.23) mm rot=Zero layer=Top
C16 ( 56.80, 6.23) mm rot=Zero layer=Top
C17 ( 12.80, 39.23) mm rot=Zero layer=Top
C18 ( 64.30, 16.23) mm rot=Zero layer=Top
C19 ( 63.80, 36.73) mm rot=Zero layer=Top
C20 ( 64.30, 12.23) mm rot=Zero layer=Top
Loading
Loading