Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: truePre-merge checks:
  |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Title check |  |
This assessment has not completed. The check will be retried on the next pre-merge check run. |
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled.
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
To identify as a server SDK, the agent string needs to include `ably-pubsub-server`. We only sent `ably-pubsub-python`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Drop the README note on token auth and 40167
A server client declares itself a server, and under token auth Ably accepts that only from a signed x-ably-clientType JWT claim; native Ably tokens can't carry it and are rejected with 40167. Tests of general token behaviour now use JWTs carrying the claim. Tests whose subject is native tokens are skipped until Ably can accept them from a server. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Port the two renewal tests that still used native tokens to JWTs, and say why the publish error tests call time()
AndyTWF
force-pushed
the
server-side-agent
branch
from
November 11, 2026 11:14
cf1442a to
1f18dc2
Compare
Validate the agents option, keep Options.agents from altering the header, and correct the README's TLS-off auth advice
Check token clientIds from the JWT claims, count failed requests in the protocol harness instead of calling time(), and share the native-token skip reason
ubuntu-latest now resolves to 26.04, where setup-python has no 3.9 build, so the lint job fails before running. check.yml already pins ubuntu-22.04 for the same reason. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to identify as a server SDK, the agent string needs to include
ably-pubsub-server. We currently send onlyably-pubsub-python. This PR addsably-pubsub-serveralongside it.Breaking for native-token auth: Ably accepts a server declaration under token auth only from a signed
x-ably-clientType=serverJWT claim, which native Ably tokens can't carry, so a server authenticating with a native token is now rejected with 40167. Tests about native tokens are skipped; the other token tests now use JWTs with the claim.🤖 Generated with Claude Code