[ttypic]

Follow-ups to the review comments on #712.

getFallbackHosts no longer returns an error

• getFallbackHosts now returns just []string.
• validate() is removed. It existed only to return that error from NewHTTPClient.
• The dead error handling in the HTTP fallback path and in realtime connect is removed. Realtime connect still tries the primary host first, then the shuffled fallbacks.

No behaviour change.

ErrChannelReleaseInvalidState is exported

• ErrChannelReleaseInvalidState is now re-exported from both entry points, like the other Err… constants.
• It's removed from the deliberate omissions in server/pubsub/reexport_test.go.
• The Release doc comment and UPDATING.md now name the constant.

Summary by CodeRabbit

• New Features
  • Added a named error code for attempts to release a channel that is not in a releasable state.
• Documentation
  • Clarified that releasing a channel in an invalid state returns error 90011 with status 400, leaves the channel unchanged, and requires detaching it first.
• Refactor
  • Simplified fallback host handling during client setup and connection.

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 2e57a5e0-0874-4f8c-b397-91759ad8386e

Commits

Reviewing files that changed from the base of the PR and between 6415cc6 and 06198ca.

Files selected for processing: 10

• UPDATING.md
• device/pubsub/api.go
• internal/ably/export_test.go
• internal/ably/http_client.go
• internal/ably/options.go
• internal/ably/options_test.go
• internal/ably/realtime_channel.go
• internal/ably/realtime_conn.go
• server/pubsub/api.go
• server/pubsub/reexport_test.go

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The change removes the error result from fallback-host selection and its callers. It also exports ErrChannelReleaseInvalidState from both pubsub packages and updates the related release documentation and re-export test.

Changes

Fallback Host Selection

Layer / File(s)	Summary
Fallback host lookup and callers internal/ably/options.go, internal/ably/export_test.go, internal/ably/http_client.go, internal/ably/realtime_conn.go, internal/ably/options_test.go	getFallbackHosts and its test wrapper now return only host slices. HTTP and realtime connection code no longer handles lookup errors. Tests use the single-value result and retain their host assertions.

Channel Release Error Export

Layer / File(s)	Summary
Release error documentation and exports internal/ably/realtime_channel.go, device/pubsub/api.go, server/pubsub/api.go, server/pubsub/reexport_test.go, UPDATING.md	Both pubsub packages export ErrChannelReleaseInvalidState. The release documentation names the error constant, and the re-export test includes it in its checks.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Refactor

Possibly related PRs

• ably/ably-go#718: This PR adds the error constant to the same pubsub re-export contract.
• ably/ably-go#719: This PR also changes fallback-host handling and removes a failing path from getFallbackHosts.

Suggested reviewers: sacoo7, lmars

Merge Risk: Minimal · up to 06198

The change preserves fallback behavior and consistently exposes the existing release error without establishing a material merge risk.

Pre-merge checks: 3 · 1 · 1

Failed checks: 1 warning · 1 inconclusive

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documenta…	Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check		The title identifies an internal review branch but does not describe the primary changes, such as simplifying fallback-host handling or re-exporting ErrChannelReleaseInvalidState.	Replace the branch-style title with a concise summary of the main change, for example: "Simplify fallback host handling and re-export channel release error".

Passed checks: 3 passed

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 2 functions across 9 files. (1 skipped: 1 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Finishing Touches

Generate docstrings

• Commit to this branch
• Create a new PR

Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

_{A rabbit checks the host list twice,
Then finds no error in the slice.
A named release code joins the line,
Through both pubsub doors it shines.
The docs now tell its code and state.}

[splindsay-92]

LGTM