[RaphaelFakhri]

Description

PresenceGetWithWaitForSync(wait bool) ignores its argument and always sets waitForSync to true. As a result, RealtimePresence.GetWithOptions(ctx, PresenceGetWithWaitForSync(false)) still blocks until the presence sync completes, which contradicts the documented behavior (RTP11c1).

This change assigns the wait value to the option.

Testing

Adds TestPresenceGetOptions_WaitForSync_RTP11c1, which checks the default, true, and false cases.

go test ./ably -run TestPresenceGetOptions_WaitForSync_RTP11c1 -count=1 -v

Without the fix, the false case fails and the other two cases pass. With the fix, all three cases pass.

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: e49afc1a-59a7-48ef-b8f5-30b92e58608b

Commits

Reviewing files that changed from the base of the PR and between 6fc28af and 92b327b.

Files selected for processing: 2

• internal/ably/realtime_presence.go
• internal/ably/realtime_presence_internal_test.go

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

CodeRabbit Verify

• Run CodeRabbit Verify to test the changes in this pull request.

[RaphaelFakhri]

Rebased onto main after the 2.0.0 restructure. TestPresenceGetOptions_WaitForSync_RTP11c1 passes, and fails on main for the false case.