Enable tiff reader to read tiff from a stack with user specified step size #9
Enable tiff reader to read tiff from a stack with user specified step size #9xs254 wants to merge 4 commits into
Conversation
z to z-1
Stepread v1
Correct confusing naming of variable and title in the tutorial
|
Hello, Thank you for the pull request. I appreciate the extensive write-up of your changes. Overall, this new feature looks great, but I will make some adjustments for improved compatibility with the current version of cpp-tiff. I will change the input parameter to be [start end step] so it does not affect current function calls. I will also move the sliceStep arg to the end of the function call with a default value of 1 for the same reason. Also, readTiffParallelBak is necessary as some tiff files (very rarely) will fail with the strip reading method, so I would also have to implement this there. I'm fine with there not being support for ImageJ images for now as I can add that later if someone requests it. I am very busy with other projects at the moment, but I will integrate these changes when I have more time. Thanks, Matthew Mueller |
Feature description
This feature enables
parallelReadTiffto read slices from a stack with user specified step size byim = parallelReadTiff(filename,[start step end]);in addition to the existingim = parallelReadTiff(filename,[start end]);im = parallelReadTiff(filename);This feature can be useful for users who want to:
Major commits for the feature:
src/parallelreadtiff.cpp
readTiffParallelaccepts extra argumentsliceStepand loop throughdirbased onsliceStep.readTiffParallelWrapperHelperacceptszRangeof length 3 by interpreting it as [start step end].mexSrc/parallelreadtiffmex.cpp
mexSrc/tests.m
parallelReadTiffin three different modes.Minor commits for practical reason:
CMakeLists.txt
include_directories(${CMAKE_BINARY_DIR}/dependencies/zlib-1.2.8)is added to solve the compilation error during cmake with MINGW64 on windows:mexSrc/compile_parallelReadTiff.m
Limitation: