Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #166
trodden pauseis meant to stop both capture and recall, and the hooks honor it, but the MCP server'strodden_recallandtrodden_explaintools never looked at the pause flag. With one procedure learned for "Page 2 in src/paginate.js repeats the last product from page 1" and Trodden paused, callingtrodden_recallover MCP with a similar prompt still returned the full<trodden-memory>block, andtrodden_explainreturned the scores plus the same procedure. An agent connected through MCP kept getting procedures while the user believed recall was off.Both tools share
recall_text, so it now checksstore.paused()right after opening the store, the same check the prompt and error hooks make, and returns "Trodden is paused. Runtrodden resumeto recall procedures again." instead of recalling. The tools still succeed rather than erroring, since a paused Trodden is a normal state, and the text tells the agent why nothing came back.trodden_list,trodden_showandtrodden_statusare left alone on purpose. They browse what is stored, like the matching CLI commands, which also keep working while paused, andtrodden_statusalready reports the pause.To reproduce, I built the binary, used a scratch
TRODDEN_HOME, ingested a transcript from a small git repository to learn one procedure, rantrodden pause, and drovetrodden mcpover stdio. Before the change both tools returned the procedure. After it both return the paused message, and aftertrodden resumethey return the procedure again. A new unit test pauses a fresh home and checks that recall and explain both return the paused message, then resumes and checks that they no longer do. It fails without the change.