Repository navigation
Release notes list squash-merged pull requests too - #33
Merged
Merged
Conversation
Since pull requests started being squash-merged (from #24), the release notes found no merge commits and came out empty but for the changelog link, as on 0.18.0 and 0.19.0. A squashed pull request is now found by the "(#N)" its commit ends with, and its own commits are fetched from GitHub, so each one's full message is listed as before. Merge commits still work the same. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🚀 Deploying Preview to Cloudflare 🚀Preview Deployments by commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release notes for 0.18.0 and 0.19.0 were empty but for the "Full changelog" link.
Why: from PR #24 on, PRs have been squash-merged (one commit, "Title (#30)") instead of merged with a "Merge pull request #30" commit.
.github/release-notes.shonly looked for merge commits, so it found no PRs at all.What changed: the script now also recognises squashed PRs by the
(#N)at the end of their commit, and fetches the PR's own commits from GitHub (pull/N/head, which GitHub keeps even after the branch is deleted), so each commit's full message is listed just as before. Merge commits work as they did: regenerating 0.17.0's notes gives exactly what's published.Docs/tooling only: no version bump, no release.
Try it
gh pr checkout 33 && git fetch --tags .github/release-notes.sh 0.19.0 v0.19.0 .github/release-notes.sh 0.18.0 v0.18.0Fixing the two published releases: once you're happy, their notes can be regenerated with
gh release edit v0.19.0 --notes-file <(.github/release-notes.sh 0.19.0 v0.19.0)(same for 0.18.0). I haven't touched the published releases.🤖 Generated with Claude Code