Repository navigation
Conversation
Use explicit keyboard-interactive-compatible options for agent guide fetches, explain OpenSSH option precedence, and preserve host-key and identity-key checks. Amp-Thread-ID: https://ampcode.com/threads/T-b58ef7fb-f69f-471f-8a0c-02453b35793c Co-authored-by: Amp <amp@ampcode.com>
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues block the instruction-only SSH guidance changes and corresponding assertion updates.
No open issues 🎉
What changed in this PR
This instruction-only change addresses OPE-94 by making OpenLore’s keyless SSH guide-fetch commands compatible with agents that otherwise enable batch mode. Authentication implementation and permissions remain unchanged.
Changes:
- Add explicit SSH options and closed stdin to setup, connection, and guide-fetch examples.
- Explain option precedence while preserving host-key verification, identity keys, and stdin for piped writes.
- Update embedded and rendered instruction assertions to match the revised commands.
| File | Description |
|---|---|
pkg/openlore/skill_examples_test.go |
Update the rendered teach-command assertion. |
internal/skills/skills_test.go |
Update the embedded setup-fetch assertion. |
docs/how-to/usage.md |
Document keyless SSH options and safety constraints. |
assets/skills/teach.md |
Revise connection checks and guide handoffs. |
assets/skills/setup.md |
Revise onboarding and deployment guide fetches. |
assets/skills/openlore/SKILL.md |
Explain keyless access and read/write stdin handling. |
assets/skills/agents.md |
Update skill installation and one-shot SSH guidance. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linear issue
Fixes OPE-94.
Diagnosis
OpenLore's keyless SSH path uses keyboard-interactive authentication with zero challenges, while retaining public-key authentication so keyed clients keep their identities. Agents that add
BatchMode=yesdisable keyboard-interactive, so a fresh keyless client cannot fetchsetupeven though a terminal client can. OpenSSH uses the first value for each option, so simply appendingBatchMode=noafter an agent-suppliedBatchMode=yesdoes not fix it.Fix
ssh -o BatchMode=no -o KbdInteractiveAuthentication=yes … </dev/nullcommands in teach's setup/connection/guide handoffs and setup's follow-up guide fetches.noneauthentication, new HTTP endpoints, or permission-system changes.Verification
Commands ran in
nix develop --command:go test -race ./internal/skills ./pkg/shell/cmds ./assets -count=1passed.go test -race -short ./...passed repository-wide after updating the rendered teach-example assertion, which had expected the previous plain SSH command.go vet ./...andgo build ./...passed.git diff --checkpassed.IdentityFile=noneandIdentityAgent=none:BatchMode=yesexited 255 withPermission denied (publickey,keyboard-interactive); the documented explicit options and closed stdin exited 0 and returned the setup guide. Disabling keyboard-interactive also failed as expected.BatchMode=yes.Selection
Selected by Linear creation date, oldest first. Older unresolved issues were skipped: OPE-65 lacks enough server evidence for its historical transport failure; OPE-74's comment confirms genuinely distinct on-disk files and needs a case/content policy decision; OPE-77 and OPE-88 are already In Progress; OPE-89 and OPE-91 are In Review with open PRs; OPE-90 deliberately implements literal heredocs and is awaiting a maintainer decision on changing that design.
Agent thread
Implemented in this scheduled Amp child thread.
Do not merge automatically.