Repository navigation
Conversation
Remove the stock embedded production config so config-free startup does not require openlore.sh auth state. Preserve optional custom embedding and fail-closed explicit auth configuration. Make deployment cleanup tolerate an absent embedded config, update setup guidance, and cover fresh-directory server construction. Amp-Thread-ID: https://ampcode.com/threads/T-c5ddd6ba-2734-4020-9636-53e46c684e5e Co-authored-by: Amp <amp@ampcode.com>
There was a problem hiding this comment.
🟢 Approval recommended
The supplied review evidence identifies no active issues requiring resolution.
No open issues 🎉
What changed in this PR
Restores config-free local startup by removing the bundled production configuration, allowing ordinary builds to use existing defaults without requiring production authentication files.
Changes:
- Removes the stock embedded config while preserving support for custom embedded and external configs.
- Makes Railpack cleanup tolerate the missing config and updates the source-build setup guide.
- Adds a fresh-directory server-construction regression test covering listener, authentication, and read-only defaults.
| File | Description |
|---|---|
railpack.json |
Makes embedded-config removal tolerate an absent file. |
railpack-plan.json |
Applies the same cleanup change to the build plan. |
cmd/openlore/main_test.go |
Tests fresh-directory server construction and local defaults. |
assets/skills/setup.md |
Clarifies cleanup and configuration precedence for source builds. |
assets/config/openlore.yml |
Deletes the production fallback so ordinary builds use built-in defaults. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linear issue
Fixes OPE-91.
Diagnosis
Without an on-disk openlore.yml, the CLI loaded the tracked embedded production config. It required ./config/lore.json, enabled openlore.sh token/passkey settings, and selected a writable production overlay. Fresh-directory server construction failed with
loading auth config: open ./config/lore.json: no such file or directory.Fix
Verification
All commands ran in the repository Nix development shell.
go test ./cmd/openlore -run "^TestFreshInstallServer$" -count=1failed with the exact missing-auth-file error.go test -race ./cmd/openlore ./internal/config ./assets ./pkg/openlore -count=1passed (non-short affected suites).go test -race -short ./...passed across the repository.go vet ./...andgo build ./...passed.go generate ./docs/...produced no tracked changes; gofmt, git diff --check, and both Railpack JSON parses passed.openlore ./docsfrom a config-free directory: banner reportedconfig: defaults; anonymous HTTP API and session-initialized MCP reads returned the fixture with exit_code 0; SSH read with an unregistered ephemeral key returned the same fixture.Agent thread
Implemented by the scheduled Amp child thread.
Do not merge automatically.