Repository navigation
Fix/concurrency - #56
Merged
Merged
Conversation
JesusMcCloud
commented
Jul 22, 2026
JesusMcCloud
commented
Contributor
- Support all KMP targets
- Logging through Napier is only supported on
- Android (ART)
- JVM
- iOS
- tvOS
- macOS
- JVM
- Logging on other targets defaults to NOOP
- Logging through Napier is only supported on
- Kotlin 2.4.0
- Fix race condition thanks to latest ANTLR 1.0.13
Contributor
Author
|
Yes, it is large, but i also moved everything to conventions and matrix testing. i also had to fan out the logger implementation and discriminate between patforms that support napier and ones that don't. For these reasons it is all way messier than it needs to be. |
Member
|
@codex review |
nodh
approved these changes
Jul 23, 2026
| @@ -1,18 +1,14 @@ | |||
| package at.asitplus.jsonpath | |||
|
|
|||
| //import io.github.aakira.napier.Napier | |||
| * JVM | ||
| * Logging on other targets defaults to NOOP | ||
| * Kotlin 2.4.0 | ||
| * Fix race condition thanks to latest ANTLR 1.0.13 |
Member
There was a problem hiding this comment.
but libs.versions.toml says 1.0.12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.