Repository navigation
Move portfolio navigation into top-right hamburger menu - #41
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c2c98054d5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .portfolio-menu-panel{ | ||
| position:absolute; | ||
| top:60px; | ||
| right:0; | ||
| width:min(286px,calc(100vw - 28px)); |
There was a problem hiding this comment.
On short viewports, such as phones in landscape or a browser at high zoom, this fixed panel needs roughly 400px of vertical space and begins about 67px from the top. Because it has neither a viewport-bounded max-height nor vertical scrolling, the lower navigation items and shortcuts extend beyond the viewport and cannot be reached by scrolling the page. Add a height constraint based on the viewport and enable overflow-y: auto.
Useful? React with 👍 / 👎.
| <b>FIYA</b> | ||
| </a> | ||
| <details className="portfolio-menu"> | ||
| <summary aria-label="Open portfolio navigation"> |
There was a problem hiding this comment.
For screen-reader users, opening this native disclosure exposes an expanded state while its accessible name remains “Open portfolio navigation”; activating it at that point actually closes the menu. This produces a contradictory action label whenever the menu is open, so use a state-neutral name such as “Portfolio navigation” or update the label to “Close…” based on the disclosure state.
Useful? React with 👍 / 👎.
Changes the portfolio navigation from the bottom floating dock to the requested top-right hamburger/dropdown.