Repository navigation
[Refactor] Remove no-explicit-any suppressions: batch 1 (utils) - #2281
Conversation
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one): 1
Please check the settings in the CodeRabbit UI or the
|
|
No code issues found. See session Reviewed 5d9ad84 |
Review statusThis PR was opened by an automated account. A human maintainer must verify the change intent, provenance, and validation before merging. Current step: The required review sequence passed. Remaining merge requirements apply. Review-state labels are managed by this workflow; do not edit them manually. |
Self-review summaryNo blocking findings.
Validation: 230 focused tests passed. Root lint and type checks passed. The full extension suite passed 12,000 tests. The repository-wide test run passed all 14 tasks. Browser proof is not applicable because this is a type-only change. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Co-authored-by: Roomote <roomote@roomote.dev>
Related GitHub Issue
No GitHub issue was provided for this maintenance campaign.
Description
This is batch 1 of the campaign to remove all bulk
@typescript-eslint/no-explicit-anysuppressions.anytypes across 13src/utilsfiles with precise types, generics,unknownwith narrowing, and typed test doubles.utilsentries fromsrc/eslint-suppressions.json.The stricter types make utility code and tests easier to check and maintain. This work supports the reliability roadmap.
Campaign batching plan
Test Procedure
pnpm lint: 11 tasks passed.pnpm check-types: 11 tasks passed.pnpm --dir src test: 12,000 passed, 39 skipped.pnpm test: 14 tasks passed, including the full extension suite.utilsentries were removed.git diff --check: passed.Pre-Submission Checklist
Visual Snapshots
Not applicable. This PR has no UI changes.
Videos (interaction / animation only)
Not applicable. This PR has no interaction or animation changes.
Documentation Updates
Additional Notes
The first extension run found missing build assets in the fresh sandbox. The suite passed after the required build. A later repository-wide run flaked in two
extension.spec.tsfocus-tracker tests. Those 24 tests passed in isolation. The full repository-wide rerun passed.Get in Touch
Discord: 0x7777777_