Skip to content

[Refactor] Remove no-explicit-any suppressions: batch 1 (utils) - #2281

Merged
edelauna merged 1 commit into
mainfrom
feature/remove-any-suppressions-utils-37ej3iv2h8z6b
Oct 31, 2026
Merged

edelauna merged 1 commit into
mainfrom
feature/remove-any-suppressions-utils-37ej3iv2h8z6b

Conversation

@zoomote2

@zoomote2 zoomote2 Bot commented Oct 31, 2026

Copy link
Copy Markdown
Contributor

​Created by Roomote. Follow up by mentioning @roomote, in the web UI, or in Discord.

Related GitHub Issue

No GitHub issue was provided for this maintenance campaign.

Description

This is batch 1 of the campaign to remove all bulk @typescript-eslint/no-explicit-any suppressions.

  • Replace 221 explicit any types across 13 src/utils files with precise types, generics, unknown with narrowing, and typed test doubles.
  • Prune all 13 utils entries from src/eslint-suppressions.json.
  • Reduce the ledger from 3,766 to 3,545 suppressions across 338 to 325 files.
  • Preserve runtime behavior and existing test assertions.

The stricter types make utility code and tests easier to check and maintain. This work supports the reliability roadmap.

Campaign batching plan

Test Procedure

  • Focused utility suites: 230 passed.
  • pnpm lint: 11 tasks passed.
  • pnpm check-types: 11 tasks passed.
  • pnpm --dir src test: 12,000 passed, 39 skipped.
  • pnpm test: 14 tasks passed, including the full extension suite.
  • Suppression audit: 3,766 to 3,545. Only utils entries were removed.
  • git diff --check: passed.

Pre-Submission Checklist

  • Issue Linked: No GitHub issue was provided for this maintenance campaign.
  • Scope: This PR covers only batch 1 of the suppression-removal campaign.
  • Self-Review: I reviewed the complete diff with care.
  • Writing Style: The title and description use short, direct sentences.
  • Testing: Focused and full validation passed.
  • Test Helpers (test changes only): Shared helpers cover mechanical setup. Scenario-specific mocks and assertions remain visible.
  • Visual Snapshot (UI changes only): Not applicable. This PR has no UI changes.
  • Documentation Impact: No user-facing documentation update is required.
  • Contribution Guidelines: I read and agree to the Contributor Guidelines.

Visual Snapshots

Not applicable. This PR has no UI changes.

Videos (interaction / animation only)

Not applicable. This PR has no interaction or animation changes.

Documentation Updates

  • No documentation updates are required.
  • Yes, documentation updates are required.

Additional Notes

The first extension run found missing build assets in the fresh sandbox. The suite passed after the required build. A later repository-wide run flaked in two extension.spec.ts focus-tracker tests. Those 24 tests passed in isolation. The full repository-wide rerun passed.

Get in Touch

Discord: 0x7777777_

@coderabbitai

coderabbitai Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are limited based on label configuration.

🏷️ Required labels (at least one): 1
  • coderabbit-review-active

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@zoomote2

zoomote2 Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor Author

No code issues found. See session

Reviewed 5d9ad84

@github-actions

github-actions Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

Review status

This PR was opened by an automated account. A human maintainer must verify the change intent, provenance, and validation before merging.

Current step: The required review sequence passed. Remaining merge requirements apply.

Review-state labels are managed by this workflow; do not edit them manually. community-approved is managed the same way — do not add or remove it manually. It signals a fresh community code approval for the current head as an advisory priority only; maintainer review is still required.

@zoomote2

zoomote2 Bot commented Oct 31, 2026

Copy link
Copy Markdown
Contributor Author

Self-review summary

No blocking findings.

  • The diff is limited to the 13 utils suppression entries and their corresponding source or test files. webview-ui is unchanged.
  • No replacement as any, @ts-ignore, or @ts-expect-error was added. Structural test-double assertions are documented at their construction sites.
  • The normalizeToolSchema overloads preserve the existing record-based call signature while exposing the non-object inputs the runtime already handles.
  • The safe-write changes preserve the interruption and rollback fault-injection scenarios. All related tests pass.
  • The suppressions ledger only shrank: 3,766 to 3,545 suppressions across 338 to 325 files.

Validation: 230 focused tests passed. Root lint and type checks passed. The full extension suite passed 12,000 tests. The repository-wide test run passed all 14 tasks. Browser proof is not applicable because this is a type-only change.

@codecov

codecov Bot commented Oct 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@edelauna
edelauna marked this pull request as ready for review October 31, 2026 19:11
@edelauna
edelauna enabled auto-merge October 31, 2026 19:13
@edelauna
edelauna added this pull request to the merge queue Oct 31, 2026
Merged via the queue into main with commit 24da00f Oct 31, 2026
38 checks passed
@edelauna
edelauna deleted the feature/remove-any-suppressions-utils-37ej3iv2h8z6b branch October 31, 2026 19:23
edelauna pushed a commit that referenced this pull request Nov 2, 2026
Co-authored-by: Roomote <roomote@roomote.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants