Repository navigation
[Chore] Close lint coverage and knip hygiene gaps - #2280
Conversation
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one): 1
Please check the settings in the CodeRabbit UI or the
|
|
No new code issues found. The only new commit is a merge of Reviewed 07fb3e1 |
Self-review summaryI reviewed the complete 13-file diff against
Validation on the final branch passed: 12 lint tasks, the root script typecheck plus 11 package typechecks, 14 test tasks with 12,003 extension and 2,245 webview tests, both knip modes with zero hints, 8 knip policy tests, 6 Code QA policy tests, and the full Prettier check. Earlier runs hit the known |
Review statusThis PR was opened by an automated account. A human maintainer must verify the change intent, provenance, and validation before merging. Current step: The required review sequence passed. Remaining merge requirements apply. Review-state labels are managed by this workflow; do not edit them manually. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
…-2jj44n69c6pch # Conflicts: # webview-ui/eslint.config.mjs
* chore: close lint and knip hygiene gaps * fix: address review findings on lint and knip hygiene --------- Co-authored-by: Roomote <roomote@roomote.dev> Co-authored-by: Elliott de Launay <edelauna@gmail.com>
Upstream Zoo-Code-Org#2280 dropped the global "**/__tests__/**!" knip ignore, so rollback.ts is now reachable through its spec in the development run. The leftover "src/core/checkpoints/rollback.ts" ignore entry therefore became a configuration hint, which "knip --treat-config-hints-as-errors" turns into a knip failure, while "knip --production" still needs the file excused because no production consumer exists in this unit yet. Express the same intent with the workspace's existing "!" entry convention (core/checkpoints/rollback.ts!) and drop the redundant ignore entry. Locally: knip, knip --production and node --test scripts/knip-policy.test.mjs all pass.
Related GitHub Issue
No GitHub issue number was supplied with this maintenance request.
Description
This change closes the lint-coverage and knip-hygiene quick wins from the tooling audit. It supports Reliability First by making local and CI checks cover the same files.
process.scripts/*.ts. Two small script type errors are fixed.There are no user-facing functionality changes. No React rules were added to the CLI. The broad E2E and root script knip ignores remain unchanged.
Test Procedure
pnpm lint: 12 tasks passed.pnpm check-types: the root script gate and 11 package tasks passed.pnpm test: 14 tasks passed. This included 12,003 extension tests and 2,245 webview tests.pnpm knip: zero findings and zero config hints.pnpm knip:production: zero findings and zero config hints.pnpm test:knip-policy: 8 tests passed.pnpm test:code-qa-ci: 6 tests passed.pnpm format:check: passed.Pre-Submission Checklist
Visual Snapshots
Not applicable. This PR has no UI changes.
Videos (interaction / animation only)
Not applicable. This PR has no interaction or animation changes.
Documentation Updates
Additional Notes
Earlier full runs hit the known
__tests__/extension.spec.tsactivation and focus-tracker flake. The spec passed alone with 24 tests. The final full run passed with no source changes between runs.Visual proof is not applicable because this PR only changes tooling and test configuration.
Get in Touch
0x7777777_