[Refactor] Add test-utils guardrails and convert remaining stragglers

.github/pull_request_template.md

@@ -40,6 +40,7 @@ Write the steps that test your changes. This helps reviewers check your work.
 - [ ] **Self-Review**: I reviewed my own code with care.
 - [ ] **Writing Style**: The PR title and description use Simplified Technical English (ASD-STE100): short sentences, plain words, active voice, one idea per sentence, no contractions.
 - [ ] **Testing**: New and/or updated tests have been added to cover my changes (if applicable).
+- [ ] **Test Helpers** (test changes only): Shared test helpers (`src/test-utils/`, `@/utils/test-utils`) are used only for mechanical duplication; test intent and scenario-specific mocks remain visible.
 - [ ] **Visual Snapshot** (UI changes only): If a user would notice this change at a glance (layout, theme tokens, brand elements, empty/error states), I added or updated a `*.visual.tsx` snapshot in `webview-ui/`. See `webview-ui/AGENTS.md` → "When a UI change needs a snapshot".
 - [ ] **Documentation Impact**: I checked if my changes need documentation updates (see "Documentation Updates" section below).
 - [ ] **Contribution Guidelines**: I read and agree to the [Contributor Guidelines](/CONTRIBUTING.md).

src/api/providers/__tests__/github-copilot.spec.ts

@@ -119,7 +119,7 @@ const mockLanguageModelChat = {
 }
 
 describe("connectGitHubCopilot", () => {
-	beforeEach(() => vi.clearAllMocks())
+	beforeEach(() => clearAllMocks())
 
 	it("authenticates through VS Code and selects only Copilot models", async () => {
 		vi.mocked(vscode.authentication.getSession).mockResolvedValue({
@@ -413,7 +413,7 @@ describe("Copilot model capabilities", () => {
 	}
 
 	beforeEach(() => {
-		vi.clearAllMocks()
+		clearAllMocks()
 		mockLanguageModelChat.countTokens.mockResolvedValue(10)
 		mockLanguageModelChat.sendRequest.mockImplementation(async () => ({
 			stream: (async function* () {
@@ -1322,7 +1322,7 @@ describe("getGitHubCopilotModels", () => {
 		...overrides,
 	})
 
-	beforeEach(() => vi.clearAllMocks())
+	beforeEach(() => clearAllMocks())
 
 	it("describes each model by identity and by the capabilities the host reports", async () => {
 		vi.mocked(vscode.lm.selectChatModels).mockResolvedValue([

src/api/providers/__tests__/io-intelligence.spec.ts

@@ -9,6 +9,7 @@ import { ioIntelligenceDefaultModelId, providerIdentifiers } from "@roo-code/typ
 
 import { buildApiHandler } from "../../index"
 import { asyncStreamFrom, collectStream } from "../../../test-utils/stream"
+import { clearAllMocks } from "../../../test-utils/reset"
 import { IOIntelligenceHandler } from "../io-intelligence"
 import { getModels } from "../fetchers/modelCache"
 
@@ -42,7 +43,7 @@ const loggedText = (spy: { mock: { calls: unknown[][] } }) =>
 
 describe("IOIntelligenceHandler", () => {
 	beforeEach(() => {
-		vi.clearAllMocks()
+		clearAllMocks()
 		vi.mocked(getModels).mockResolvedValue({
 			"meta-llama/Llama-3.3-70B-Instruct": {
 				maxTokens: 8192,

src/api/providers/__tests__/nanogpt.spec.ts

@@ -9,6 +9,7 @@ import { nanoGptDefaultModelId, providerIdentifiers } from "@roo-code/types"
 
 import { buildApiHandler } from "../../index"
 import { asyncStreamFrom, collectStream } from "../../../test-utils/stream"
+import { clearAllMocks } from "../../../test-utils/reset"
 import { createReadFileTool } from "../../../core/prompts/tools/native-tools/read_file"
 import { NanoGptHandler } from "../nanogpt"
 import { getModels } from "../fetchers/modelCache"
@@ -45,7 +46,7 @@ const messages: Anthropic.Messages.MessageParam[] = [{ role: "user", content: "H
 
 describe("NanoGptHandler", () => {
 	beforeEach(() => {
-		vi.clearAllMocks()
+		clearAllMocks()
 		vi.mocked(getModels).mockResolvedValue({
 			"model:thinking": {
 				maxTokens: 128000,

src/api/providers/__tests__/vscode-lm.spec.ts

@@ -6676,7 +6676,7 @@ describe("getVsCodeLmModels", () => {
 		...overrides,
 	})
 
-	beforeEach(() => vi.clearAllMocks())
+	beforeEach(() => clearAllMocks())
 
 	it("returns serializable model metadata with host-reported image support", async () => {
 		const model = liveModel({ capabilities: { supportsImageToText: true } })

src/core/config/__tests__/CustomModesManager.spec.ts

@@ -198,7 +198,7 @@ describe("CustomModesManager", () => {
 			const firstResult = await manager.getCustomModes()
 
 			// Reset mock to verify it's not called again
-			vi.clearAllMocks()
+			clearAllMocks()
 
 			// Setup mocks again for second call
 			;(fileExistsAtPath as Mock).mockImplementation(async (path: string) => {
@@ -236,7 +236,7 @@ describe("CustomModesManager", () => {
 			await manager.getCustomModes()
 
 			// Reset mocks to track new calls
-			vi.clearAllMocks()
+			clearAllMocks()
 
 			// Update a mode
 			const updatedMode: ModeConfig = {
@@ -260,7 +260,7 @@ describe("CustomModesManager", () => {
 			await manager.updateCustomMode("mode1", updatedMode)
 
 			// Reset mocks again
-			vi.clearAllMocks()
+			clearAllMocks()
 
 			// Next call should read from file again (cache invalidated)
 			await manager.getCustomModes()
@@ -282,7 +282,7 @@ describe("CustomModesManager", () => {
 			await manager.getCustomModes()
 
 			// Reset mocks to track new calls
-			vi.clearAllMocks()
+			clearAllMocks()
 
 			// Delete a mode
 			await manager.deleteCustomMode("mode1")
@@ -296,7 +296,7 @@ describe("CustomModesManager", () => {
 			})
 
 			// Reset mocks again
-			vi.clearAllMocks()
+			clearAllMocks()
 
 			// Next call should read from file again (cache invalidated)
 			await manager.getCustomModes()
@@ -321,7 +321,7 @@ describe("CustomModesManager", () => {
 			await manager.getCustomModes()
 
 			// Reset mocks to track new calls
-			vi.clearAllMocks()
+			clearAllMocks()
 
 			// Setup for update
 			const updatedMode: ModeConfig = {
@@ -346,7 +346,7 @@ describe("CustomModesManager", () => {
 			await manager.updateCustomMode("mode1", updatedMode)
 
 			// Reset mocks again
-			vi.clearAllMocks()
+			clearAllMocks()
 
 			// Setup mocks again
 			;(fileExistsAtPath as Mock).mockImplementation(async (path: string) => {
@@ -387,7 +387,7 @@ describe("CustomModesManager", () => {
 				await manager.getCustomModes()
 
 				// Reset mock to verify it's not called again
-				vi.clearAllMocks()
+				clearAllMocks()
 
 				// Setup mocks again for second call
 				;(fileExistsAtPath as Mock).mockImplementation(async (path: string) => {
@@ -408,7 +408,7 @@ describe("CustomModesManager", () => {
 				currentTime += 11000
 
 				// Reset mocks again
-				vi.clearAllMocks()
+				clearAllMocks()
 
 				// Setup mocks again for third call
 				;(fileExistsAtPath as Mock).mockImplementation(async (path: string) => {

src/eslint.config.mjs

@@ -27,6 +27,15 @@ const testPathTraversalSelectors = [
 	},
 ]
 
+// Test-utils rollout guardrail: lanes converted to the shared reset helper
+// stay converted. Use clearAllMocks from test-utils/reset.
+const testResetHelperSelector = {
+	selector:
+		"CallExpression[callee.object.name='vi'][callee.property.name='clearAllMocks'], CallExpression[callee.object.name='vitest'][callee.property.name='clearAllMocks']",
+	message:
+		"Use the shared clearAllMocks() helper from src/test-utils/reset instead of calling vi.clearAllMocks() directly.",
+}
+
 /** @type {import("eslint").Linter.Config} */
 export default [
 	...config,
@@ -85,9 +94,6 @@ export default [
 			"@typescript-eslint/no-floating-promises": "error",
 		},
 	},
-	{
-		ignores: [".stryker-tmp", "webview-ui", "out"],
-	},
 	{
 		// Tests inside __tests__/ directories must not traverse 3+ levels above
 		// the test file. That escapes the src/ package root and makes Turbo
@@ -112,4 +118,34 @@ export default [
 			"no-restricted-syntax": ["error", ...testPathTraversalSelectors, ...apiProviderTestSelectors],
 		},
 	},
+	{
+		// Test-utils rollout guardrail: lanes converted to the shared reset
+		// helpers stay converted. Use clearAllMocks from test-utils/reset.
+		// no-restricted-syntax replaces earlier blocks for the same files, so
+		// repeat the traversal selectors here.
+		files: [
+			"core/config/__tests__/**/*.ts",
+			"services/code-index/**/__tests__/**/*.ts",
+			"integrations/terminal/**/__tests__/**/*.ts",
+		],
+		rules: {
+			"no-restricted-syntax": ["error", ...testPathTraversalSelectors, testResetHelperSelector],
+		},
+	},
+	{
+		// Same guardrail for the API provider lane; this block also replaces the
+		// API provider hygiene selectors, so repeat those too.
+		files: ["api/providers/__tests__/**/*.ts"],
+		rules: {
+			"no-restricted-syntax": [
+				"error",
+				...testPathTraversalSelectors,
+				...apiProviderTestSelectors,
+				testResetHelperSelector,
+			],
+		},
+	},
+	{
+		ignores: [".stryker-tmp", "webview-ui", "out"],
+	},
 ]

src/services/code-index/__tests__/code-index-manager-registry.spec.ts

@@ -1,5 +1,6 @@
 import * as vscode from "vscode"
 import { makeExtensionContext, makeTextDocument, makeTextEditor, makeUri } from "../../../test-utils/vscode"
+import { clearAllMocks } from "../../../test-utils/reset"
 import { CodeIndexManager } from "../manager"
 import { CodeIndexManagerRegistry } from "../code-index-manager-registry"
 import { CodeIndexWorkspaceScope } from "../code-index-workspace-scope"
@@ -25,7 +26,7 @@ describe("CodeIndexManagerRegistry", () => {
 	let second: vscode.WorkspaceFolder
 
 	beforeEach(() => {
-		vi.clearAllMocks()
+		clearAllMocks()
 		context = makeExtensionContext()
 		first = { uri: makeUri("/first"), name: "first", index: 0 }
 		second = { uri: makeUri("/second"), name: "second", index: 1 }

src/services/code-index/__tests__/code-index-scope.spec.ts

@@ -1,4 +1,5 @@
 import { makeExtensionContext } from "../../../test-utils/vscode"
+import { clearAllMocks } from "../../../test-utils/reset"
 import { CodeIndexScope } from "../code-index-scope"
 import { CodeIndexStatusManager } from "../code-index-status-manager"
 import { CodeIndexManagerRegistry } from "../code-index-manager-registry"
@@ -9,7 +10,7 @@ vi.mock("../code-index-manager-registry", () => ({
 }))
 
 describe("CodeIndexScope", () => {
-	beforeEach(() => vi.clearAllMocks())
+	beforeEach(() => clearAllMocks())
 
 	it("creates, initializes and disposes its status manager", () => {
 		const context = makeExtensionContext()

src/services/code-index/__tests__/code-index-status-manager.spec.ts

@@ -6,6 +6,7 @@ import {
 	makeExtensionContext,
 	makeWorkspaceConfiguration,
 } from "../../../test-utils/vscode"
+import { clearAllMocks } from "../../../test-utils/reset"
 import { CodeIndexManager } from "../manager"
 import { CodeIndexStateManager } from "../state-manager"
 import { CodeIndexStatusManager, type CodeIndexStatus } from "../code-index-status-manager"
@@ -68,7 +69,7 @@ describe("CodeIndexStatusManager", () => {
 	let disposeWorkspaceFolders: ReturnType<typeof vi.fn<() => void>>
 
 	beforeEach(() => {
-		vi.clearAllMocks()
+		clearAllMocks()
 		vi.mocked(vscode.workspace.getConfiguration).mockReturnValue(makeWorkspaceConfiguration())
 		Object.defineProperty(vscode.window, "activeTextEditor", { configurable: true, value: undefined })
 		Object.defineProperty(vscode.workspace, "workspaceFolders", {

src/services/code-index/__tests__/code-index-workspace-scope.spec.ts

@@ -1,4 +1,5 @@
 import { makeExtensionContext, makeUri } from "../../../test-utils/vscode"
+import { clearAllMocks } from "../../../test-utils/reset"
 import { CodeIndexManager } from "../manager"
 import { CodeIndexWorkspaceScope } from "../code-index-workspace-scope"
 import { CodeIndexStateManager } from "../state-manager"
@@ -13,7 +14,7 @@ vi.mock("../manager", () => ({
 }))
 
 describe("CodeIndexWorkspaceScope", () => {
-	beforeEach(() => vi.clearAllMocks())
+	beforeEach(() => clearAllMocks())
 
 	it("owns a guarded workspace indexing manager and recreates it after disposal", () => {
 		const scope = new CodeIndexWorkspaceScope("/workspace", makeUri("/workspace"), makeExtensionContext())

src/services/code-index/embedders/__tests__/embedder-validation-manager.spec.ts

@@ -1,6 +1,7 @@
 import { TelemetryService } from "@roo-code/telemetry"
 import { TelemetryEventName } from "@roo-code/types"
 import { t } from "../../../../i18n"
+import { clearAllMocks } from "../../../../test-utils/reset"
 import embeddings from "../../../../i18n/locales/en/embeddings.json"
 import { OpenAiEmbedder } from "../openai"
 import { EmbedderValidationManager } from "../embedder-validation-manager"
@@ -14,7 +15,7 @@ vi.mock("@roo-code/telemetry", () => ({
 describe("EmbedderValidationManager", () => {
 	const manager = new EmbedderValidationManager()
 
-	beforeEach(() => vi.clearAllMocks())
+	beforeEach(() => clearAllMocks())
 
 	it.each([{ valid: true }, { valid: false, error: "Invalid credentials" }])(
 		"preserves the validation result %j without reporting an exception",

src/services/code-index/processors/__tests__/processor-factories.spec.ts

@@ -1,6 +1,7 @@
 import * as vscode from "vscode"
 import ignore from "ignore"
 import { makeExtensionContext } from "../../../../test-utils/vscode"
+import { clearAllMocks } from "../../../../test-utils/reset"
 import { Package } from "../../../../shared/package"
 import { CacheManager } from "../../cache-manager"
 import { BATCH_SEGMENT_THRESHOLD } from "../../constants"
@@ -30,7 +31,7 @@ vi.mock("../scanner")
 vi.mock("../file-watcher")
 
 describe("processor factories", () => {
-	beforeEach(() => vi.clearAllMocks())
+	beforeEach(() => clearAllMocks())
 	afterEach(() => vi.restoreAllMocks())
 
 	function dependencies() {

src/services/code-index/vector-store/__tests__/vector-store-factory.spec.ts

@@ -1,5 +1,6 @@
 import { providerIdentifiers } from "@roo-code/types/provider-identifiers"
 import { getDefaultModelId, getModelDimension } from "../../../../shared/embeddingModels"
+import { clearAllMocks } from "../../../../test-utils/reset"
 import type { CodeIndexConfig } from "../../interfaces/config"
 import { QdrantVectorStore } from "../qdrant-client"
 import { VectorStoreFactory } from "../vector-store-factory"
@@ -15,7 +16,7 @@ describe("VectorStoreFactory", () => {
 	let config: CodeIndexConfig
 
 	beforeEach(() => {
-		vi.clearAllMocks()
+		clearAllMocks()
 		vi.mocked(getDefaultModelId).mockReturnValue("default-model")
 		vi.mocked(getModelDimension).mockReturnValue(undefined)
 		factory = new VectorStoreFactory()

webview-ui/eslint.config.mjs

@@ -46,4 +46,32 @@ export default [
 			"no-undef": "off",
 		},
 	},
+	{
+		// Test-utils rollout guardrail: component specs render through the shared
+		// renderWithExtensionState helper instead of hand-wrapping providers.
+		// Hook specs (including .tsx ones) keep local renderHook wrappers since
+		// they pass a specific QueryClient instance to the hook, and Playwright
+		// visual fixtures mount real providers inside stories rather than Vitest
+		// renders.
+		files: ["src/components/**/__tests__/**/*.tsx"],
+		ignores: [
+			"src/components/**/hooks/**/__tests__/**/*.tsx",
+			"src/components/**/__tests__/**/*.visual.fixture.tsx",
+		],
+		rules: {
+			"no-restricted-imports": [
+				"error",
+				{
+					paths: [
+						{
+							name: "@tanstack/react-query",
+							importNames: ["QueryClientProvider"],
+							message:
+								"Use renderWithExtensionState from @/utils/test-utils instead of hand-wrapping QueryClientProvider in component specs.",
+						},
+					],
+				},
+			],
+		},
+	},
 ]