Skip to content

chore: fix minor style nits in tree-sitter spec files #297

Open

Description

@edelauna

Two low-priority style nits found during review of #249.

#1 — Mixed \s* and {n} quantifiers in TOML spec

File: src/services/tree-sitter/__tests__/parseSourceCodeDefinitions.toml.spec.ts:43–44

Line 43 uses \|\s*\[\[products\]\] (flexible whitespace) and line 44 uses the same flexible prefix but then {2} to pin the two spaces before the comment. The mixing is semantically correct but is the only line in the file that combines \s* with a trailing {n}, which may surprise future readers expecting \s* everywhere. Consider using \s+ instead of {2} for consistency, or adding a brief comment explaining the intent.

#2 — Missing blank line between it() blocks in Solidity spec

File: src/services/tree-sitter/__tests__/parseSourceCodeDefinitions.solidity.spec.ts:40

The "should parse state variable declarations" block runs directly into "should parse function declarations" without a blank line separator, unlike every other adjacent it() pair in the file. Pre-existing issue, not introduced by #249.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions